Comments (7)
Can you tell me what version you are using?
from victoria.
v5.1.3
from victoria.
Actually i think it even only removed 1 entry. Since i also call skip after it that's why 2 where skipped.
So that function seems to only get rid of the first track in the queue
from victoria.
Okay so I've fixed this one. The initial version of that method is this:
public ICollection<T> Remove(int index, int count) {
if (index < 0) {
throw new ArgumentOutOfRangeException(nameof(index));
}
if (count < 0) {
throw new ArgumentOutOfRangeException(nameof(count));
}
if (Count - index < count) {
throw new ArgumentException("Math");
}
var tempIndex = 1;
var removed = new T[count];
lock (_list) {
var currentNode = _list.First;
while (tempIndex != index && currentNode != null) {
tempIndex++;
currentNode = currentNode.Next;
}
var nextNode = currentNode?.Next;
for (var i = 0; i < count && currentNode != null; i++) {
var tempValue = currentNode.Value;
removed[i] = tempValue;
_list.Remove(currentNode);
currentNode = nextNode;
nextNode = nextNode?.Next;
}
return removed;
}
}
I might have to optimize it a bit more or if others can help out in my Guild but if not then this would be it.
from victoria.
Can you push this so i can alter it?
from victoria.
Sure thing! Also if you want to test out the changes: https://www.myget.org/F/yucked/api/v3/index.json
from victoria.
I'll be closing this issue. Feel free to reopen it if it doesn't work out.
from victoria.
Related Issues (20)
- [Bug]: Player state is playing yet tracking is not being processed HOT 11
- [Bug]: Various types of System.InvalidOperationException thrown at shut-down. HOT 2
- [Bug]: TrackStartEvent fires twice
- LavaPlayer.VoiceChannel value doesn't change after moving to another channel HOT 1
- [Feature Request]: TrackEncoder HOT 8
- [Bug]: Expected end of string, but instead reached end of data. HOT 5
- [Bug]: https://yucked.github.io/Victoria/ Endpoint returns 404 HOT 1
- [Bug]: SkipAsync does not work for child classes of LavaTrack HOT 1
- [Bug]: Equalizer does not propagate updates? HOT 4
- [ BUG ] LavaPlayer.Vueue should be LavaPlayer.Queue and should be referred to something similar throughout the code HOT 4
- [ BUG ] .PlayAsync with PlayArgs always throws NullReferenceException HOT 1
- [ BUG ] GetPlayer&TryGetPlayer fails with KeyNotFoundException HOT 1
- [ BUG ] Some video make Victoria throw a silent exception, making all event not tigger anymore HOT 1
- [ BUG ] Some video make Victoria throw a silent exception, making all event not tigger anymore HOT 1
- How do I set up my services when using v6 version ? HOT 2
- [ BUG ] Tracks sometimes get stuck at the end of playback. HOT 5
- Can no longer add the lava node to IServiceCollection HOT 3
- [ BUG ] LavaTrackConvert fails to successfully
- [ BUG ] LavaTrackConverter fails to deserialize back to a LavaTrack
- [ BUG ] Victoria sending blank or slightly wrong payloads for the Stop and Resume functions to work expectedly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from victoria.