Code Monkey home page Code Monkey logo

Comments (12)

pukkandan avatar pukkandan commented on May 21, 2024 1

I just saw this: axcore/tartube#254, which I assume is the reason you opened this issue here.

I would actually suggest you give an option in tartube to choose the package name and binary name separately. This will allow your users to install any fork using the git+https://github.com/pukkandan/yt-dlp.git@release even if the fork they want to use has no pypi package

from yt-dlp.

axcore avatar axcore commented on May 21, 2024 1

As far as I can tell, not practical.

Consider this situation: the user installs youtube-dlc, then later installs yt-dlp. Later they decide to switch back to youtube-dlc (from Tartube, or from the command line). Only someone who has examine the source code knows that the earlier installation has been overwritten.

Now the user tries to uninstall youtube-dlc. Suddenly yt-dlp doesn't work any more, because yt-dlp's executable has been removed.

from yt-dlp.

pukkandan avatar pukkandan commented on May 21, 2024

When I changed the project name to yt-dlp, there were a few reasons I decided to keep the binary and module name as youtube-dlc. Most of them are small things, but the main reason is that it is honestly quite a bit of work to change it everywhere without messing anything up, while there are almost no benefits in doing so.

It is probably easier to change tartube's code to allow for different package and binary names. But, if instead, you or anyone else wants to make a PR here with the necessary changes, I'd be glad to merge it.

from yt-dlp.

candrapersada avatar candrapersada commented on May 21, 2024

or use Releases · pukkandan_yt-dlp for a while
image

from yt-dlp.

axcore avatar axcore commented on May 21, 2024

but the main reason is that it is honestly quite a bit of work to change it everywhere without messing anything up

How would you feel about using the name youtube-dlp? blackjack4494 has already done the hard work of converting youtube-dl to youtube-dlc throughout the code, but only where necessary. So, in theory, we only need to update that subset of changes.

Anyway, I'm happy to do the PR, so you can decide for yourself whether it's worth merging or not, I just need your preferred choice of name.

from yt-dlp.

pukkandan avatar pukkandan commented on May 21, 2024

Anyway, I'm happy to do the PR

Thanks

you can decide for yourself whether it's worth merging or not

If you make the PR, I'll definitely merge it. I just dont wanna put in the effort

I just need your preferred choice of name.

yt-dlp since it's the repo name and I'm already using it as pypi package name

from yt-dlp.

pukkandan avatar pukkandan commented on May 21, 2024

I understand. While I can think of ways to workaround this problem, I can see how this could be annoying, especially to non tech-savy users

from yt-dlp.

candrapersada avatar candrapersada commented on May 21, 2024

tartube can use the yt-dlp custom path by using
python3 Downloads/youtube-dlc https://www.youtube.com/watch?v=CG8CX5mx2mk or python3 /home/user/Downloads/youtube-dl https://www.youtube.com/watch?v=CG8CX5mx2mk without without installing the yt-dlp package to pypi
image
image

from yt-dlp.

axcore avatar axcore commented on May 21, 2024

Yes, but I will remove that soon, for the reasons above.

from yt-dlp.

pukkandan avatar pukkandan commented on May 21, 2024

The module name has been completely changed to yt-dlp

from yt-dlp.

candrapersada avatar candrapersada commented on May 21, 2024

how to remove file youtube-dlc from pip3?

from yt-dlp.

pukkandan avatar pukkandan commented on May 21, 2024

If you just want to overwrite it with youtube-dlc, use pip3 install youtube-dlc

Or uninstall and reinstall yt-dlp

pip3 uninstall yt-dlp
pip3 install yt-dlp

from yt-dlp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.