The issue I attempted to linkpreview</co

Pages with meta tags, all of whose property attr are unrelated to OG properties ruins the preview about jekyll-linkpreview HOT 2 CLOSED

Clpsplug commented on June 18, 2024

Pages with meta tags, all of whose property attr are unrelated to OG properties ruins the preview

from jekyll-linkpreview.

Comments (2)

ysk24ok commented on June 18, 2024 1

Thank you for reporting this.

In addition to page.meta_tags['property'].empty?, check for the total absence of property attributes whose value matches regex og:.*.

Right. We should check these four properties as https://ogp.me/#metadata says they are required for every page.

og:title
og:type
og:url
og:image

I'm going to prep a PR, but should the 'using .best_title accessor instead' fix be a separate PR from the 'non-OGP meta tags messing with the factory selection' fix?

I think so, and could you put #37 (comment) as a new issue so a PR can close the corresponding issue?

from jekyll-linkpreview.

Clpsplug commented on June 18, 2024

I also noticed that this specific page has quite a unique structure - the <title> tag is in the <body> tag. For this reason, the preview was missing a title even if I applied my proposed fix locally. This is because MetaInspector::Parsers::TextsParser.title only looks at the title tag within the head tag.

We cannot blame them, though; having a <title> tag outside of the <meta> tag technically violates the HTML spec.

But there is an alternative: the .best_title accessor, which also looks at the title tag within the body tag. We could also modify this part below to produce the best result possible.

jekyll-linkpreview/lib/jekyll-linkpreview.rb

Lines 117 to 121 in 61c8b0b

    
           class NonOpenGraphPropertiesFactory 
        
             def from_page(page) 
        
               NonOpenGraphProperties.new( 
        
                 page.title, page.url, get_description(page), page.host) 
        
             end

I'm going to prep a PR, but should the 'using .best_title accessor instead' fix be a separate PR from the 'non-OGP meta tags messing with the factory selection' fix?

from jekyll-linkpreview.

Recommend Projects