Comments (7)
Thx! Just to be sure, what was your When no chord note
setting? Silence
?
Also, in your situation you expected no events at all, right? You haven't been feeding chords as I understand, so either with Silence
or Latch last chord
you shouldn't be seeing note ON events in any case.
from arpligner.
@riban-bw If you want to have a quick try: just comment lines 192 & 193 in Arp.cpp
:
else // No mappings means we add the NOTE OFF as it is:
midibuf.addEvent(msg, 0);
(I added that because it seemed to fix some rare stuck notes cases, but it's certainly what causes your problem here. But it's not multi-instance specific, probably you'll have the same behaviour in the same conditions in multi-chan mode)
EDIT: I applied that in latest master
from arpligner.
Although that stops note-off messages being sent I am still not seeing any note-on messages being sent in multi-instance mode.
[Edit] Actually - in multi-instance mode the pattern instance behaves as if there is not chord instance connected. I wonder if the IPC is working as expected on this platform:
Arpligner.so: ELF 32-bit LSB pie executable, ARM, EABI5 version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=7f85e19443224c9c448b21e863a81d5907db2092, with debug_info, not stripped
from arpligner.
@riban-bw Then that's probably that. That's what's expected to happen if the two instances are isolated and both create their own "singleton" object each one on their side.
from arpligner.
How would mult-instance be instantiated successfully?
from arpligner.
@riban-bw Multi-instance relies on SingletonHolder
from JUCE: https://github.com/juce-framework/JUCE/blob/2b16c1b94c90d0db3072f6dc9da481a9484d0435/modules/juce_core/memory/juce_Singleton.h
But it's not clear to me yet what in their implementation makes the shared pointer unique...
from arpligner.
Okay so it probably just boils down to the fact that the singletonHolder attached to the class is made static
:
static juce::SingletonHolder<Classname, juce::CriticalSection, doNotRecreateAfterDeletion> singletonHolder;
So yes I'd guess that, for it to work, the exact same process has to load (at least on Linux) the various plugin instances, so that static singletonHolder
may be the same for each. Is the "scope" of static mutable members a well-defined property in C++ standards anyway? (I know this could qualify as "dabbling with black magic" here...)
from arpligner.
Related Issues (8)
- Improve the level of lenience re. timing of note off events on the chord chan
- LV2 parameters not exposed to host HOT 2
- Support remapping of poly aftertouch events (on pattern tracks)
- win32 build would be nice, thanks in advance.
- github build artifacts are currently expired HOT 2
- On Bitwig on Windows only, plugin parameters are not reloaded correctly HOT 1
- Fix Raspberry Pi CI build
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arpligner.