trimStart and trimEnd about you-dont-need-lodash-underscore HOT 11 OPEN

I disagree. I'd prefer to not have needless regex in my code.

from you-dont-need-lodash-underscore.

This repo is not forcing anyone to follow all the native alternatives presented.

I agree to this ( and PR welcome 😃 )

from you-dont-need-lodash-underscore.

For me the real benefit of this project, including its eslint configuration, is to remove unnecessary code from my bundles when I can go by with a lighter alternative. If you take a look at trimEnd's implementation you'll see that it's not at all a one liner or anything like that. It even depends on a few other lodash internal stuff (the same goes for trimStart).

However, for the most common use case where the second parameter is not provided, because you want to trim whitespace, the alternative solution involves a lot less code, a simple one-liner using a native javascript method, and a relatively simple regex. I think it's worth to show users the simpler alternative in this case. I'd even go as far as to say that it should be recommended, if we ever have a recommended preset. For users that do not want to write the regex, as is your case, the rule can always be turned off in the eslintrc file.

from you-dont-need-lodash-underscore.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trimStart

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trimEnd

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/Trim

from you-dont-need-lodash-underscore.

Thanks @gnapse
PR welcome

from you-dont-need-lodash-underscore.

Isn't this repo about recommendations to users of lodash of when they could go by with a relatively simple native alternative? I understand that some users may still prefer lodash's way of doing some particular task, and that's fine. This repo is not forcing anyone to follow all the native alternatives presented.

from you-dont-need-lodash-underscore.

I guess, but it's going to cause a detailed initial configuration or annoying future changes when the "all" preset is too restrictive. Perhaps we need a "recommended" preset.

from you-dont-need-lodash-underscore.

I guess, but it's going to cause a detailed initial configuration or annoying future changes when the "all" preset is too restrictive. Perhaps we need a "recommended" preset.

I think you are talking about the eslint config?

from you-dont-need-lodash-underscore.

I think you are talking about the eslint config?

Isn't that the function of this project? But, yes, and this specifically: https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/blob/master/configuring.md#now-configure-your-plugin

from you-dont-need-lodash-underscore.

Isn't that the function of this project?

The eslint doesn't really include things like these. Only the simple ones like concat() or map() (the ones you can easily replace lodash with the corresponding native methods without thinking too much). However, the readme can go a bit future as per @gnapse mentioned above.

from you-dont-need-lodash-underscore.

I see the readme as a good support for the eslint config. The primary goal is to be told "you don't need this".

from you-dont-need-lodash-underscore.