Code Monkey home page Code Monkey logo

Comments (3)

matthewdias avatar matthewdias commented on June 9, 2024

Would it make sense to only apply this for files named with standard repo names (README.md, CONTRIBUTING.md, etc), and follow the existing behaviour otherwise?

from vmd.

yoshuawuyts avatar yoshuawuyts commented on June 9, 2024

I think treating leading slashes as relative to the repository, rather than the OS is a smell. I see no reason why ./my-image.jpg or my-image.jpg doesn't suffice. /my-image.jpg reads as if it's part of root; whereas it's not.

from vmd.

matthewdias avatar matthewdias commented on June 9, 2024

Yeah, I agree that's the right way to specify paths. Only reason I opened this for discussion is that many others do this in their git repos, which means that when others clone and attempt to use vmd to view the readme, the images don't work. It's not totally necessary so use your judgement if you think this should be implemented or not.

from vmd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.