I tried using <a href="https://github.com/petkaantonov/bluebird/blob/master/API.md#nod

I was just a little bit off 🌈 🐰 <img class="emoji" title=":shipit:" alt=":shipit:" s

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-u

Convert to node-style callback? about asyncawait HOT 3 CLOSED

yortus commented on August 17, 2024

Convert to node-style callback?

from asyncawait.

Comments (3)

reggi commented on August 17, 2024

I was just a little bit off 🌈 🐰 🍖

function execModify(command, manipulators, callback) {
  return asyncawait(function(command, manipulators) {
    var exec = Promise.promisify(childProcess.exec);
    var stdout = await(exec(command))[0];
    if (!manipulators) return stdout;
    for (var key in manipulators) {
      var manipulator = manipulators[key];
      stdout = manipulator(stdout);
    }
    return stdout;
  })(command, manipulators).nodeify(callback);
}

from asyncawait.

yortus commented on August 17, 2024

Hi @reggi, a couple of suggestions:

For better performance, run the var exec = Promise.promisify... line only once, not on every call
async.cps is a variant of async that will return a node-style callback function, no need for .nodeify.

With those two changes, your code would look something like:

var exec = Promise.promisify(childProcess.exec);

var execModify = async.cps (function (command, manipulators) {
    var stdout = await (exec(command))[0];
    if (!manipulators) return stdout;
    return _.map(manipulators, function(manipulator) {
      return manipulator(stdout);
    });
  });

// execModify now has a node-style API, so call it like:
execModify(myCommand, myManipulators, function (err, result) {...});