Await / PromisifyAll function not completing? about asyncawait HOT 5 CLOSED

Hi @carn1x. Promise.promisifyAll expects a node-style function signature, i.e. a function accepting a callback as its last argument, where that callback will receive the error/result. Your exports.add function doesn't follow that convention - it has two callbacks. So Promise.promisifyAll will not work as expected there.

from asyncawait.

Ooh, thanks, totally missed that! Is there a another route I could go or do I really need to refactor to node-style callbacks? Everything seems to be pushing me in that direction, but I was hoping to avoid it!

from asyncawait.

To avoid refactoring, you could write your own promisifyAll utility function that works with your convention.

Otherwise, unless there's some special reason to keep the two-callback style, I'd consider refactoring to make your code more interoperable with everything else in node-land. I'm not sure why you are doing it that way to begin with - is it required by some library you are using?

from asyncawait.

I do plan to re-factor to this convention anyway eventually, however I have a lot of existing code and unit tests based on the current method, so I was hoping to convert my tests and app code separately.

As for why I'm following this method, I think it's just the tutorial I started learning node with. After a while I came to realize that I was going against the grain so I'm now beginning the process of converting. But I'd like to do so incrementally rather than just break everything :). Thanks for the advice!

from asyncawait.

No problem, I'll close this issue since there's nothing much else to do here.

from asyncawait.