Code Monkey home page Code Monkey logo

Comments (2)

yortus avatar yortus commented on July 18, 2024

Hi @Kaos1337,

The downloadFile() function is not awaitable in its current form. Try this:

function downloadFile(uri, filename) {
    return new Promise(function (resolve, reject) {
        console.log("[downloadFile] definitiveName: " + filename); <--- print correctly the definitive name
        request(uri)
        .pipe(fs.createWriteStream(filesFolder + filename))
        .on('close', function(err) {
            if(err) {
                reject(err);
            }
            else {
                console.log("[downloadFile] Downloaded: " + filename); <--- print correctly the definitive name
                resolve(filename); <-- the return of the function
            }
        });
    });
}

Explanation: The original downloadFile() function runs the first console.log, then starts the asynchronous request(uri) operation, then immiediately returns undefined. This undefined is what is being passed to await in the other function you provided. I have wrapped the code inside downloadFile in a promise, and returned the promise. The promise gets resolved once the file is downloaded. await receives this promise and waits for it to resolve before continuing.

BTW wrap your code in triple backticks to make it easier to read in github comments, like so:

```
function foo() { ... }
```

from asyncawait.

Kaos1337 avatar Kaos1337 commented on July 18, 2024

Thank you, works!
I've also corrected my first message as you suggested.

from asyncawait.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.