Code Monkey home page Code Monkey logo

Comments (6)

yortus avatar yortus commented on July 18, 2024

Does connection.query also return a promise? If not, you'll have to make a version that does return a promise first. I don't know what DB library you are using so I'll assume it doesn't return promises. knex.js returns Promises so if you can use that I recommend it, as the code will interoperate much more easily with async/await style.

Anyhow, if your connection.query method only takes callbacks, then do something like this first:

// NB: if you are using iojs, Promise is already defined as a global
var Promise = require('bluebird');

function getTitles() {
    return new Promise(function (resolve, reject) {
        connection.query('SELECT * FROM titles', function (err, rows) {
            if (err) return reject(err);
            resolve(rows);
        });
    });
}

Then you can write some other async function that calls getTitles like this:

var doStuffAsync = async (function () {
    ...
    var titles = await (getTitles());
    ...
    var result = someOtherFunc(titles);
    return result;
});

When called, doStuffAsync will return a promise of its result.

On the other hand, if connection.query returned a promise directly, you wouldn't need getTitles at all, you could just do:

var doStuffAsync = async (function () {
    ...
    var titles = await (connection.query('SELECT * FROM titles'));
    ...
    var result = someOtherFunc(titles);
    return result;
});

from asyncawait.

jenokizm avatar jenokizm commented on July 18, 2024

Thanks! tomorrow, as will certainly try and describe the time.
ps its mysql connection https://www.npmjs.com/package/mysql

from asyncawait.

yortus avatar yortus commented on July 18, 2024

FYI, there are some promise-oriented wrappers for the mysql library:

I suggest using one of these, since they will work directly with async/await. No need to manually wrap or 'promisify' anything.

from asyncawait.

jenokizm avatar jenokizm commented on July 18, 2024

I get to set the old python. I liked more your way, but tell me if I can call a doStuffAsync func in addition? Why it again operates asynchronously, and I do not get the desired result (
ashampoo_snap_2015 06 01_20h29m39s_002_

from asyncawait.

yortus avatar yortus commented on July 18, 2024

doStuffAsync() is an ordinary (but asynchronous) function that returns a promise. The promise instance is what you can see in your screenshot above.

You need to await the asynchronous function call to suspend the caller until the promise resolves - ie titles = await (doStuffAsync()).

It's important to understand that to use await you need to be inside the definition of another async function. That is because suspending a function requires some kind of coroutine support, which normal functions do not provide, hence the async wrapper function.

That means that your outermost layer of functionality (perhaps the API you expose to your module's consumers) would still expose promise-returning functions.

So if doStuffAsync() was some public method, consumers would use it like a normal promise-returning function, ie doStuffAsync().then(function (result) { ... }).

from asyncawait.

yortus avatar yortus commented on July 18, 2024

Closing this as there seems no further action to be taken. Feel free to open another issue if you have more questions.

from asyncawait.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.