How about recommending the use of 'prettier' in contribution guide? about yorkie-js-sdk HOT 3 CLOSED

@hackerwins Thank you for providing usable information.
In my opinion, newline per chain call are not the problem, it seems to be affected by the printWidth option of prettier.
In 1.x versions, if there were more than 3 calls, a newline occurred. In the current 2.x version this has been fixed, we are using version 2.0.5.

(reference)
version 1.x playground
version 2.x playground

So I tested it with the code of the part in problem.

printWidth: 80

    if (logger.isEnabled(LogLevel.Trivial)) {
      logger.trivial(
        changes
          .map(
            (change) =>
              `${change
                .getID()
                .getAnnotatedString()}\t${change.getAnnotatedString()}`,
          )
          .join('\n'),
      );
    }

printWidth: 90

    if (logger.isEnabled(LogLevel.Trivial)) {
      logger.trivial(
        changes
          .map(
            (change) =>
              `${change.getID().getAnnotatedString()}\t${change.getAnnotatedString()}`,
          )
          .join('\n'),
      );
    }

printWidth: 100

    if (logger.isEnabled(LogLevel.Trivial)) {
      logger.trivial(
        changes
          .map((change) => `${change.getID().getAnnotatedString()}\t${change.getAnnotatedString()}`)
          .join('\n'),
      );
    }

However, if we modify it and use it, it affects other parts as well.
For example

-    pbSetOperation.setParentCreatedAt(
-      toTimeTicket(setOperation.getParentCreatedAt()),
-    );
+    pbSetOperation.setParentCreatedAt(toTimeTicket(setOperation.getParentCreatedAt()));

Looking at this, I think there is a part that we have to give up in order for use prettier.
Let me know what you think.

from yorkie-js-sdk.

For now, it would be nice to leave this issue open and wait for an update on Prettier.

from yorkie-js-sdk.

Yes. It would be nice to describe Prettier in Contribution.md. I thought it would be nice to have Prettier run automatically before commit using a tool like husky.

However, it could not be introduced due to the line break issue below. Do you have any idea about ​​this issue?
#44 (comment)

from yorkie-js-sdk.