Support Quill embeds(image, video) about yorkie-js-sdk HOT 8 CLOSED

Conversation with @hackerwins
Embed data (video, image ..) has a size of 1 like space bar in content and decided to use attributes field.

After this issue is solved, PR can be registered.

from yorkie-js-sdk.

@ppeeou Sure. If you have any questions while proceeding, please let me know.

from yorkie-js-sdk.

@ppeeou Can I try this issue if you are okay?

from yorkie-js-sdk.

Could I try this issue??!

from yorkie-js-sdk.

@hackerwins In the case of Quill, the value contains the type according to text, images, and video.
This value is already loaded in memory, so it can easily distinguish the type.

However, in the case of yorkie, when serializing value and storing it on the server and passing it to the client, the client must handle whether the value is images, video, or text through JSON.parse.

• if we don't define a type.

try{
  return JSON.parse(content) // object
}catch{
  return content; // string 
}

So, I prefer to follow Quill as it is, but I think we need to define the value inevitably. What do you think??

from yorkie-js-sdk.

@ppeeou Thanks for the good comments. It's been a while since I saw this issue, so I don't remember it well.
As you suggested, I think we should have an explicit type in RichText.

from yorkie-js-sdk.

@hackerwins

I have a question regarding this issue..!
I thought the issue only had to be extended by type

In Quill, when data such as image and video are inserted, the size is set to 1 (retain difference is 1), so it can be used like deleting text when using something like delete.

I think we should also receive the size from RichText, not the length of the string from and to (the size depends on the contentType, and the actual content can be base64, URL..)

I have no idea how to change it in the current structure 😭

from yorkie-js-sdk.

oh... yes 😵‍💫
thank you @mojosoeun

from yorkie-js-sdk.