Clear default build settings about xcodegen HOT 15 CLOSED

@keith it's implemented here #100. Have a look and see if this suits your needs 👍

from xcodegen.

@keith, I've added a followup PR #101 that allows you to fully control the setting presets. Setting this to none removes the need for the commit I noticed you have here:
lyft@3d2fe09

from xcodegen.

Interesting. This mirrors the thoughts in #77

from xcodegen.

Ah yes, I think that kind of only half captures the problem though, since even if you're not overriding the setting, you may not want it to be set in the project. This happens for us a lot in our all Swift app, where we don't really want Objective-C build settings to be set, since future developers won't know if we actually need it, or if it was just set by default by Xcode

from xcodegen.

What do you suggest as way to opt out of setting presets? There are presets for the project, debug and release configurations, each platform and each target

from xcodegen.

I guess maybe a top level attribute for this? In theory it could also be per-target, but that seems like overkill?

from xcodegen.

What about this?

options:
  clearBaseSettings: true

You can already clear debug and release settings by simply providing a different type other than debug or release

configs:
  Debug: none
  Release: none

from xcodegen.

You can already clear debug and release settings by simply providing a different type other than debug or release

Oh interesting, is that all that is used for?

from xcodegen.

Yep, that's all that does. It's documented in the Project spec

from xcodegen.

Another option is to not apply the base settings if the config type is cleared.
From this:

buildSettings += SettingsPresetFile.base.getBuildSettings()
if let type = config.type {
    buildSettings += SettingsPresetFile.config(type).getBuildSettings()
}

to this:

if let type = config.type {
    buildSettings += SettingsPresetFile.base.getBuildSettings()
    buildSettings += SettingsPresetFile.config(type).getBuildSettings()
}

from xcodegen.

I'm more for the clearBaseSettings solution. I think it's more explicit and the attribute is at the level of the project, where it's getting applied. Modifying the project configuration based on a target attribute might be too implicit for the developer who wouldn't expect the base settings to be cleared. This could be solved by adding some documentation though.

from xcodegen.

The configs aren’t a target level attribute, they live on the top level project. Also those debug and release settings actually get applied to the project, not the target

from xcodegen.

Cool! then I'd go with the solution that you proposed.

from xcodegen.

There could still be another solution to clear all the presets including those in targets. Maybe an options.applySettingPresets which could be one of the following:

• all (default)
• targets (don't apply any project settings ie, base, debug or release)
• none

What do you think?
Maybe if we had that #100 wouldn't be needed as it would be strange to set all here and none on the configs?

from xcodegen.

Awesome!!

from xcodegen.