sample() fails when array contains middleclass classes about moses HOT 7 CLOSED

Hmm, I do not think there is any problem here. Actually the problem is not related at all with Middleclass.
Documentations says _.sample returns an array of selected values or a single value when n == 1. Since in your unit test you are trying to get a single value, the value itself is returned by _.sample.

The test should have been written this way:

describe('moses sample()', function()
  it('works when array contains Vector classes', function()
    ....
    local sample = moses.sample({vector1, vector2}, 1)
    assert.is_true(sample:isInstanceOf(DenseVector))
  end)
end)

from moses.

Oh I see. Functions that return different datatypes for n=1 are very unexpected, unchainable, and "not inspired by lodash". Such functions would also require the caller to have an "if n=1" condition. I suggest that such functions are unusable.

from moses.

Strong point, taken into consideration. See commit d7e9618 which reflects the changes.

from moses.

Looks better. The function still returns a non-array for n<1, which causes the same problem. What's the purpose of having special handling for n=1? Doesn't having different codepaths for different parameter values lead to inconsistencies?

from moses.

It is fixed as of now.
Thanks for your feedback.

from moses.

Sweet 👍

from moses.

BTW, your last publish to LuaRocks was 225 days ago. You've worked on a lot of goodies since then! You can share more often -- we won't mind! :-)

from moses.