More differentiated transformation about mastodon-bot HOT 5 CLOSED

I'm ok with the idea of decoupling the transform from the account config to facilitate having different sources. It would probably be sufficient to specify the type of source e,.g: {:source :twitter ...} since the path is just an implementation detail. Pulling in aero for this might be a bit ovekill. :)

from mastodon-bot.

That seems like it could be reasonable, another option could be to add the transform rules under the config map for each service, e.g:

{:twitter
  {:access-keys ...
   :transform
   [{:accounts ["WIRED"] :include-replies? false :signature "#twitterbot"} ...]}

from mastodon-bot.

Let's call your idea no 3.

idea no 3 would have the charm, that the source credentials are very clear assigned. And I like the impression :signature binds stronger to the source. But on the other hand in combination with #46 the used target credentials are very implicit and we can not express mastodon->twitter.

What do you think about a combination of idea no 2 & no 3?
As I'm quite a fan of aero we could use aero's references.
In this case config can look like:

{:auth {:twitter { ... credentials ...}
            :mastodon { ... credentials ... }}
 :transform [
  {:source #ref [:auth :twitter] :target #ref [:auth :mastodon]
   :accounts ["WIRED"] :include-replies? false :signature "#twitterbot"} ...]}

Advantages would be:

1. we can reuse the auth-config-parts wherever we will need em.
2. direction is expressive
3. transform will become a first class citizen (namespace). And we can e.g. think about whether signature is part of transformation vs. part of mastodon-api vs. part of twitter-api.
4. we can even have more than only one credential per api - in case #46 the source mastodon account will not be the bot-account. I'm not sure, whether mastodons public timeline access will be enough.
5. It is in general a good practice to separate credentials from rest of configuration (in devops we depend heavily on git managed configuration - without exposing the credential part). We are using aroe's include in this scenario. But let's handle this argument only as a weak feeling, as I think that is not really relevant in our case.

from mastodon-bot.

done :-)

from mastodon-bot.

🎉

from mastodon-bot.