Code Monkey home page Code Monkey logo

Comments (18)

samdark avatar samdark commented on July 19, 2024

There's already a dropdown:

18qb6nvl

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024

yes, I am familiar with that downdown, but a few clicks are needed to get there, at most of the time 4 clicks

  1. click on the toolbar at the bottom
  2. click at the profile menu
  3. click at last 10
  4. find and click at the POST

When debugging a POST, preferably, I would not have to click at all but see immediately if something was wrong.

from yii2-debug.

samdark avatar samdark commented on July 19, 2024

Well, it was wrong not in the current request.

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024

I am not saying the toolbar should be removed for the current request,
I am advocating to improve visibility for non-visible requests (redirects), which I do think makes sense.

from yii2-debug.

samdark avatar samdark commented on July 19, 2024

What about AJAX requests? These are non visible as well. And there could be 100 requests while the main one is active.

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024

reporting these could be handy as well, but in a separate solution. 100 rows would now be practical as you pointed, a dropdown would fit better.

About non-ajax redirects (which will usually will be 1) what do you think about adding an extra row in de toolbar? It also improves visibility on the fact that a REDIRECT has occurred.

from yii2-debug.

samdark avatar samdark commented on July 19, 2024

OK. It makes sense overall. So:

  1. If current request was redirect, display an extra badge colored in response status of the original request.
  2. When clicked, it will lead you to previous request opened in full debugger.

Correct?

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024
  1. could be an extra badge, but I see more value in showing a complete row with the same data as the current GET request:
  • less confusing as 1 row corresponds with 1 request (better from a conceptual perspective)
  • more valuable information for the redirect (such as time/db/memory etc)
  • IMHO we can live with an extra 40px
  1. correct

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024

@samdark: why not implement both. Than the user can decide what to use.

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024

I have another usecase. I was doing some refactoring in some of my own core components and after a while I came to the conclusion that my POSTs got 5 X slower.

I can not easily be notified about this with the current toolbar. I could have when supplied with another row about the POST request, supplying me with figures about memory & total time.

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024

screenshot

This pic is to show you my intentions. The summary bar of the previous request is only shown when 302 POSTs occur.

from yii2-debug.

samdark avatar samdark commented on July 19, 2024

@dynasource affirmative. Intention understood. Overall it should be useful.

from yii2-debug.

samdark avatar samdark commented on July 19, 2024

7288372c-4101-11e5-8839-fdeeda44b8fd

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024
  • if I understand your pic correctly, I should hide double stuff like the yii logo? Will do that with opacity:0 ok?

from yii2-debug.

samdark avatar samdark commented on July 19, 2024

Well, it doesn't make sense to display it twice. Not sure how to handle it in the best way though...

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024

the current output is like this:
post-taskbar

I am using this for a while now and I am very happy with it.
Is it valuable enough to implement? If not, please tell me, than I will start to implement my own version/hook.

from yii2-debug.

samdark avatar samdark commented on July 19, 2024

Yes, I think I'll merge it. Still not sure about visual part of it. It looks a bit misleading so probably we need a way to hint that it was a redirect and that's why there are 2 rows. Something like the following:

b4b780da-5240-11e5-81a1-ef680fd1fefa

from yii2-debug.

dynasource avatar dynasource commented on July 19, 2024

true, despite the double logos etc, I liked #38 (comment) better because of design consistency.

With respect to the hint for the redirect, its quite clear with the status 302. But you have to get used to it in the beginning, thats true.

from yii2-debug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.