Sorting of debug data about yii2-debug HOT 17 CLOSED

My main motivator is to find out slow parts and optimize them.

from yii2-debug.

Personally if I want to see something (even database profiling) in order by time I find that usually I want to look at the "Profiling" tab anyway. This gives more verbose stack output than the simplified database profiling (which doesn't list things like database connection opening / closing). Additionally it does default to sort by the time column.

from yii2-debug.

+1 for sort order by time of execution. I was very confused today and spent quite some time to figure out, why some query was executed before some other query, which was not possible by looking at my code. I had to open #60 where @samdark finally pointed me to the default sorting.

To me it's quite un-intuitive.

from yii2-debug.

... or if you do default sorting by duration, then at least keep the # column intact. Why is there a 1 in that column if that wasn't the first query being executed?

from yii2-debug.

Last suggestion totally makes sense.

from yii2-debug.

Also we may consider making sorting sticky.

from yii2-debug.

My main motivator is to find out slow parts and optimize them.

Right, so sorting by duration is fine under "Profiling". But why do the same under "Database" by default? I expect to see the DB related log entries there. And log entries are usually always ordered by timestamp.

from yii2-debug.

Now what is really funny: Under "Profiling" the rows are obviously sorted by timestamp by default. :D

from yii2-debug.

@samdark my suggestion:

Use the "sort" as a module property and allow each developer to do the way he wants, specific to each panel.

Something like this:

Module.php

    public $panelSort = [
        '_default' => [
            'attributes' => ['duration', 'seq', 'type', 'query'],
            'defaultOrder' => [
                'duration' => SORT_DESC
            ]
    ];

    private function getSort($panel)
    {
        return ArrayHelper($module->panelSort, $panel, $module->panelSort['_default']);
    }

main-local.php

    [
        'bootstrap' => ['debug'],
        'modules' => [
            'debug' => [
                'class' => 'yii\debug\Module',
                'allowedIPs' => ['192.168.88.100'],
                'panelSort ' => [
                    'db' => [
                        'attributes' => ['seq', 'duration', 'type', 'query'],
                        'defaultOrder' => [
                            'duration' => SORT_ASC
                        ]
                    ]
                ]
            ]
        ]
    ]

from yii2-debug.

It's better just to make it sticky per page so when sorted once it's remembered.

from yii2-debug.

Sticky is fine. But still there should be sane defaults. I think, the current ones are not. They are exactly the opposite of what you would expect:

• Profiling: Sort by duration
• Database, Logs: Sort by timestampl

from yii2-debug.

Agree.

from yii2-debug.

This still needs to be done, please.

from yii2-debug.

@yiisoft/core-developers
Hi guys, we need more opinions here...

Edit: I can't mention teams 😯

from yii2-debug.

I've voiced my opinion already. @yiisoft/core-developers?

from yii2-debug.

@samdark I can send a PR with the above suggestion?

from yii2-debug.

It's useless, I think. Just what mikehaertl suggested would be enough.

from yii2-debug.