clientOptions false still renders JS about yii2-bootstrap5 HOT 12 CLOSED

@julianrutten thx for your offer, I think we'll merge your initial pr
Optimize where it makes sense without chaning the behavior

from yii2-bootstrap5.

@julianrutten

Breadcrumbs.php#L48

I didn't say it was impossible, I said it's not bug and you must update property comment to declare additional type.

from yii2-bootstrap5.

@julianrutten 🤦🏻‍♂️ you pass boolean value in array property

from yii2-bootstrap5.

@WinterSilence I know that, I am not the one who made this spec I am merely trying to keep it compatible. Also whats up with the attitude? You must be fun to program with lol.

from yii2-bootstrap5.

@julianrutten

trying to keep it compatible

compatible with what's?
if you want extend behaviour, then update property comment too.

from yii2-bootstrap5.

@WinterSilence The previous version of yii2 bootstrap library, you know the framework this is for that has NOT changed its major. It allowed you to skip the client side javascript to use your own. But I am kinda done with the emoticons, circle cant get square images and semver urls. I am trying to help out on an open source project here but I feel like I am overstaying my welcome. Oh might want to list this breaking change in your migration guide:
https://github.com/yiisoft/yii2-bootstrap5/blob/master/docs/guide/migrating-yii2-bootstrap.md

Good luck with the library!

from yii2-bootstrap5.

@julianrutten

The previous version of yii2 bootstrap library, you know the framework this is for that has NOT changed its major.

how does all this relate to framework? base widget don't have clientOptions property
yii2-bootstrap5 not extend classes of yii2-bootstrap4

circle cant get square

when something work not as you thinked, it's not bug. you want extend current behavior? no problem, but call a spade a spade.

It allowed you to skip the client side javascript to use your own.

if you want extend behaviour, then update property comment too.

from yii2-bootstrap5.

@WinterSilence you're right. I wouldn't say invalid, but bad style. An option would be nice anyway. I thought about do it the same way cause of habit of the programmers and it would be easier to upgrade

from yii2-bootstrap5.

@WinterSilence Once again it was in yii2-bootstrap and yii2-bootstrap4 I do not understand why you are making such a big deal here instead of just constructively trying to either reject this feature all together or come to a solution. Anyway I am not going to debate this with you because you are acting on bad faith here with the palm face emoticons and sending images and urls about stuff totally off topic. fyi: its pretty condescending to assume people don't know semver or how typed languages work, a thing for which PHP and this framework has never been known. It has been known for getting things done. Debating semantics and hammering eachother with face palm emoticons and circle cant get square images is not a part of that. You seem like a library hero to me, unknown to the world of having to rewrite 10 years of apps for the sake of strict typing applications that were never designed for that.

from yii2-bootstrap5.

@simialbi I agree it is a bad style (not the modern way anymore) but it is the way it is done in yii2 in particular. However if you prefer strict typing this library I would gladly write the changes including tests and changelog.

from yii2-bootstrap5.

@WinterSilence Okay so after having a look at the library I have absolutely no clue why this is suddenly about strict typing because this library is nowhere near type safe.
https://github.com/yiisoft/yii2-bootstrap5/blob/master/src/Toast.php#L65
DateTime that can also be a boolean
Example 2:
https://github.com/yiisoft/yii2-bootstrap5/blob/master/src/Breadcrumbs.php#L48
An array that can be a boolean (exactly the same as I proposed)

Should I go on?

from yii2-bootstrap5.

No you didnt. You acted like it was about coding, not about the comments or tests. @simialbi asked me for tests and docs, which I was planning on doing over the weekend. After that you said: 🤦🏻‍♂️ its invalid. You are just trying to not look like a total idiot now. I asked 2 times constructively how to get past this but you went on with sending random stuff just to be condescending instead of just saying: 'tests and docs and your done'. Its kind of sad to be honest.

from yii2-bootstrap5.