Code Monkey home page Code Monkey logo

Comments (4)

arogachev avatar arogachev commented on September 21, 2024 1

This may sound like a good idea, but I'm closing this because of the following reasons:

  • It doesn't fit open source specifics and our team in particular.
  • If PR already got sufficient amount of approves, according discussions automatically become non-blocking.
  • Increases complexity, especially for non core team members.
  • If it's possible for discussion to be closed - it will be closed. Github has no functionality to disallow it for now,
  • Discussed with @samdark and the conclusion was that it won't work (based on experience).
  • No one else supported this idea.

I'll take it into consideration and switch my style of handling discussions too.

Bottom line:

if you think discussion is resolved - resolve it yourself.

from docs.

arogachev avatar arogachev commented on September 21, 2024

Related - https://stackoverflow.com/questions/65401407/should-the-author-or-reviewer-resolve-conversation-when-the-comments-have-been.

from docs.

arogachev avatar arogachev commented on September 21, 2024

Another idea is to mark what is fixed completely and partially with different text tags / emojis to be able to quickly search and navigate through discussions using browser native tools.

from docs.

arogachev avatar arogachev commented on September 21, 2024

Emojis are images though and search only works in HTML.

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.