Change behaviour of `render` method about demo HOT 7 CLOSED

I think @xepozz means something like this

//abstract class Controller
protected function render(string $view, array $parameters = []): string
{
    $response = $this->responseFactory->createResponse();
    $content = $this->view->render($view, $parameters, $this);
    $response->getBody()->write($this->renderContent($content));

    return $response;
}

from demo.

View component is not aware of request-response. Its job is rendering templates. I don't think it's a good idea to couple it like suggested.

Still, I agree that it looks a bit cumbersome to create response like that (while it makes perfect sense if redirect or sending headers is involved).

Possible solutions:

1. Allow returning strings from handlers (actions).
2. Provide a shortcut method like createResponseWithBody($string).
3. ???

from demo.

If you want to render and collect result to string you can use $this->getView()->render(...);
Controller::render() is only wrapper over $view->render. I do not see any problems in returning Response

Moreover, such a template is familiar to all PHP developers (at least), because all frameworks provide such a convenient interface.

from demo.

Returning response directly from render()? Some references would not hurt...

from demo.

Yes but that would be:

protected function render(string $view, array $parameters = []): Response

from demo.

Yes but that would be:

Of course, I've just forgotten to change after copying.

from demo.

Thought more about it. It doesn't sound bad to do it.

from demo.