There is ambiguous loop in resolve_user for social auth about authx HOT 6 CLOSED

I believe some thing like below could solve this loop issue.

            resolved_username = username
            while True:
                postfix = str(i) if i > 0 else ""
                resolved_username = f"{username}{postfix}"
                existing_username = await self._repo.get_by_username(resolved_username)
                if not existing_username:
                    break
                i = i+1

from authx.

Hello, @iftenet I didn't notice that loop, but I see it can be fixed as you proposed, want to contribute and open a Pull request?

from authx.

Hello, @iftenet I didn't notice that loop, but I see it can be fixed as you proposed, want to contribute and open a Pull request?

I will be glad if you give me the opportunity to contribute.

from authx.

Hello, @iftenet I didn't notice that loop, but I see it can be fixed as you proposed, want to contribute and open a Pull request?

I will be glad if you give me the opportunity to contribute.

Yes for sure!

I will assign it as a bug and you can work on it 🚀

from authx.

@yezz123 I am going to create a PR but seems I have no permission to push.

ERROR: Permission to yezz123/authx.git denied to iftenet.

You can fork the project and try to made your changes in your fork you will find it in this way, iftenet/authx.git then a yellow head with a button create PR

from authx.

@yezz123 I am going to create a PR but seems I have no permission to push.

ERROR: Permission to yezz123/authx.git denied to iftenet.

from authx.