todomvc text disappears if you hit enter without typing about yew HOT 4 CLOSED

Related, since the model only stores a single edit_value, you can cause another bug:

1. create two todo items
2. double click on one to begin editing
3. double click on the other to begin editing
4. type some text into the first item
5. press enter in the second item

the text from the first item is transferred to the second item.

from yew.

Regarding the primary issue of this bug, adding

model.edit_value = model.entries[idx].description.clone();

to the Msg::ToggleEdit(idx) handler in update solves pressing enter immediately after entering edit mode, but it does nothing for the issue of editing multiple simultaneously.

from yew.

Personally, my thoughts lean towards the idea that having Model.edit_value be a String is fundamentally flawed, since the user could be editing more than one item at a time. I believe it makes more sense to preserve a list of items which are currently being edited, and then as the user types into a particular entry, it should update the actual Entry as each character is typed. The main reason not to go this route would be to have the option to undo if the user hit Esc.

To allow undoing, it could make sense to have a separate HashMap<usize, Entry> that contains a copy of each Entry presently being edited, keyed by the idx of the entries being edited. Changes would be reflected in real-time in the HashMap, and committed into the Vec.

The user could also be restricted to editing only one item at a time, I suppose.

from yew.

@coder543 Thank you found this bug )
This issue closed automatically, because I've merged fix of @machineloop.
You can reopen the issue if the problem not solved completely.

from yew.