JSCS + ES2015 about generator-node HOT 14 CLOSED

Unrelated but how about us just switching to ESLint? We made the switch at generator-gulp-webapp as well.

from generator-node.

JSCS is not the same as ESLint. It parse code style, not linting.

from generator-node.

ESLint checks both code style and linting.

from generator-node.

ESLint checks both code style and linting.

Yes.

from generator-node.

I know we dropped ESLint on yeoman-generator, because it kept breaking our Travis integration because breaking linting rules were changing in minor release.

If you think it's more stable now (I don't think so), feel free to give it a try.

from generator-node.

Well, do we even have much of a choice? JSCS doesn't even support ES2015 syntax completely.

If you think it's more stable now (I don't think so), feel free to give it a try.

It's getting better and better daily from what I can tell.

from generator-node.

I'm +1 to switching to ESLint where possible. Also other generators please. JSHint and JSCS aren't stable too.

from generator-node.

@robbbz Want to work on a PR for this one?

from generator-node.

@robbbz that would be awesome!

because it kept breaking our Travis integration because breaking linting rules were changing in minor release.

By the way, ESLint is still at 0.x.x versions so that's perfectly valid.

from generator-node.

I will do that.

from generator-node.

By the way, ESLint is still at 0.x.x versions so that's perfectly valid.

That's not valid as it meant breaking changes where release in patches.

from generator-node.

Is JSCS/JSHint support still meant to be optional or do we just use ESLint?

because it kept breaking our Travis integration because breaking linting rules were changing in minor release.

In minor bumps they can introduce breaking changes according to semantic versioning. You can read the specification on it on this website: http://semver.org/.

from generator-node.

@robbbz I was specifically speaking about patches versions. If things broke after we bump a version, that's fine. They were breaking when we just re-run our tests (so no version change on our side).

If we go with ESLint, we go all the way (so dropping jshint and jscs)

from generator-node.

I was specifically speaking about patches versions. If things broke after we bump a version, that's fine. They were breaking when we just re-run our tests (so no version change on our side).

Oh okay. I believe it's better now though. Also I think you won't disagree that JSHint and JSCS aren't a good solution too.

If we go with ESLint, we go all the way (so dropping jshint and jscs)

I'll keep that in mind.

from generator-node.