Code Monkey home page Code Monkey logo

Comments (22)

hemanth avatar hemanth commented on June 8, 2024

npm run scripts I would vote for bash as well. 👍

from generator-node.

stevemao avatar stevemao commented on June 8, 2024

npm run scripts
but if it gets too complex then shell

from generator-node.

stevemao avatar stevemao commented on June 8, 2024

I think if user doesn't choose a build system, the project is usually simple so the structure could be simpler: instead of having /lib/, /test/ and /bin/ folders it should be just flattened, just like https://github.com/sindresorhus/generator-nm. In fact a lot of times I just move those files manually after everything is generated. It would be great to flatten the file structure if no build system is selected.

from generator-node.

robbbz avatar robbbz commented on June 8, 2024

npm run scripts I would vote for bash as well. 👍

Npm scripts, but not bash. Bash isn't cross platform, only the part npm shims is.

from generator-node.

 avatar commented on June 8, 2024

👍

Npm scripts, but not bash. Bash isn't cross platform, only the part npm shims is.

yes :) i think @hemanth just meant that.

from generator-node.

iamstarkov avatar iamstarkov commented on June 8, 2024

voting for npm-scripts version. I chose them it turns out very well https://github.com/iamstarkov/generator-tiny-es-nm/blob/master/app/templates/_package.json#L6-L17

from generator-node.

iamstarkov avatar iamstarkov commented on June 8, 2024

I can make pull-request to bring support of raw build system here. should I?

from generator-node.

SBoudrias avatar SBoudrias commented on June 8, 2024

@iamstarkov PR is welcomed!

from generator-node.

iamstarkov avatar iamstarkov commented on June 8, 2024

I tried yesterday, but failed. the scope is very broad, should I replicate gulp flow? which step should be replicated?

from generator-node.

SBoudrias avatar SBoudrias commented on June 8, 2024

@iamstarkov test + coverage + nsp check.

We should probably drop babel from the raw build.

from generator-node.

iamstarkov avatar iamstarkov commented on June 8, 2024

I planned to respect babel option in the raw build. is it ok?

from generator-node.

SBoudrias avatar SBoudrias commented on June 8, 2024

@iamstarkov If someone wants a raw build system, I assume they'd want simplicity - and that's not babel.

from generator-node.

iamstarkov avatar iamstarkov commented on June 8, 2024

@SBoudrias but maybe they want es2015 goodies too. for example me. so if you dont mind ill try later this week to implement it again. thank you for response about pr scope.

from generator-node.

arthurvr avatar arthurvr commented on June 8, 2024

I agree with @iamstarkov, the complexity of adding Babel is still way less than having a complete Gulp build workflow.

from generator-node.

iamstarkov avatar iamstarkov commented on June 8, 2024

@SBoudrias @arthurvr as a followup i have a question, because i tried to add pure build support without removing gulp deps and it turned out to be quite messy: right now its only two branches gulp with or without es2015, if we are adding pure build then its become 4 branches: gulp or pure with or without babel. its quite complex. so the question is: why did generator-node need gulp dev-flow in the first place?

from generator-node.

SBoudrias avatar SBoudrias commented on June 8, 2024

why did generator-node need gulp dev-flow in the first place?

With mocha and istanbul, that's the easiest setup (sure beats the cli). Also, windows doesn't have && support in their cli.

from generator-node.

iamstarkov avatar iamstarkov commented on June 8, 2024

there are possible solutions for && problem like:

  • npm pre/post scripts for simple scripts
  • npm-run-all to run complicated scripts

from generator-node.

stevemao avatar stevemao commented on June 8, 2024

@iamstarkov see xojs/create-xo#3 and xojs/create-xo#6

from generator-node.

iamstarkov avatar iamstarkov commented on June 8, 2024

@stevemao sorry, dont really get what you wanted to point out

from generator-node.

stevemao avatar stevemao commented on June 8, 2024

Those issues are discussing npm pre/post scripts and && problem etc.

from generator-node.

iamstarkov avatar iamstarkov commented on June 8, 2024

yeah, i got that part and as i far as i understood pre/post scripts are doing better than &&

from generator-node.

SBoudrias avatar SBoudrias commented on June 8, 2024

Since v2.0, this ticket is now un-relevant. We don't use gulp anymore :)

from generator-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.