Comments (14)
Is there some reason package.json can't be used as a fall back ?
This has been brought up many times in the Bower issue tracker and has been declined. This is not the place to implement it.
Also it would be usefull to display which components failed to be associated with a .js
Sure, that could be useful. @robdodson what do you think?
from bower-requirejs.
Yeah it would be easy to list out the components that didn't make the cut. I'll see if I can put together a PR sometime this week.
from bower-requirejs.
I don't see why this isn't the place to implement grabbing main
from a package.json file. You're already assuming a top-level js file is the main file; how is that any better?
from bower-requirejs.
@mlmorg because package.json is for node and its main
might not be the same as the browser one or even work.
from bower-requirejs.
Sure, but doesn't a top-level js file run the same risk?
from bower-requirejs.
@mlmorg you're right.
from bower-requirejs.
I'm not opposed to adding it. Although I think the task itself could probably use some house cleaning. It's starting to turn into two giant callbacks.
from bower-requirejs.
@robdodson definitely
from bower-requirejs.
Does anyone have an example of a library that defines a main js file in package.json but not bower.json? Just so I can put together a test fixture. @anodynos @mlmorg ?
from bower-requirejs.
Backbone.js?
from bower-requirejs.
@mlmorg perfect, thanks!
from bower-requirejs.
also Underscore.js has no bower.json, but has package.json and main in it, though both of them work fine at the moment, since they have main js-file names same way as package, but for example backbone-forms doesn't have bower.json and has no main js-file named as package, so it's simply ignored, though it has main in package.json, which can be used by bower-requirejs to provide path for Require.js
from bower-requirejs.
This should be addressed by this commit in the postinstall-refactor branch (robdodson/grunt-bower-requirejs@1779f4d). There's a test for backbone-amd
which doesn't have a bower.json
but does have a package.json
which properly specifies the location of the main file. Feel free to PR additional tests if you'd like.
from bower-requirejs.
Fixed in v0.8.0
from bower-requirejs.
Related Issues (20)
- Add option to write new config file HOT 2
- Better error propagation HOT 4
- Generation doesn't work for overridden main array HOT 8
- inherit `baseUrl` from config.js if present HOT 1
- Issue saving config file
- cdnify support HOT 2
- prefix option to prefix module ids HOT 3
- ability to supply and modify config without working with files HOT 1
- Allow running inside Docker containers HOT 1
- Only add to an existing file HOT 1
- Non-destructive/additive-only mode
- yo backbone scaffolding failing due to "bower-requirejs.js" tasks...ERROR HOT 2
- Override path key HOT 1
- --transitive appears to silently fail when a Bower component specifies dependencies that are ignored in .bowerrc
- Deprecated? HOT 2
- Node packages are added to the array every run HOT 2
- Modules that support both AMD and node use node
- Tests don't pass on Windows HOT 2
- Add support for main in bower.json given as array of Strings HOT 2
- Requirejs is not added to dependencies automatically HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bower-requirejs.