Code Monkey home page Code Monkey logo

Comments (14)

sindresorhus avatar sindresorhus commented on June 30, 2024

Is there some reason package.json can't be used as a fall back ?

This has been brought up many times in the Bower issue tracker and has been declined. This is not the place to implement it.

Also it would be usefull to display which components failed to be associated with a .js

Sure, that could be useful. @robdodson what do you think?

from bower-requirejs.

robdodson avatar robdodson commented on June 30, 2024

Yeah it would be easy to list out the components that didn't make the cut. I'll see if I can put together a PR sometime this week.

from bower-requirejs.

mlmorg avatar mlmorg commented on June 30, 2024

I don't see why this isn't the place to implement grabbing main from a package.json file. You're already assuming a top-level js file is the main file; how is that any better?

from bower-requirejs.

sindresorhus avatar sindresorhus commented on June 30, 2024

@mlmorg because package.json is for node and its main might not be the same as the browser one or even work.

from bower-requirejs.

mlmorg avatar mlmorg commented on June 30, 2024

Sure, but doesn't a top-level js file run the same risk?

from bower-requirejs.

sindresorhus avatar sindresorhus commented on June 30, 2024

@mlmorg you're right.

from bower-requirejs.

robdodson avatar robdodson commented on June 30, 2024

I'm not opposed to adding it. Although I think the task itself could probably use some house cleaning. It's starting to turn into two giant callbacks.

from bower-requirejs.

sindresorhus avatar sindresorhus commented on June 30, 2024

@robdodson definitely

from bower-requirejs.

robdodson avatar robdodson commented on June 30, 2024

Does anyone have an example of a library that defines a main js file in package.json but not bower.json? Just so I can put together a test fixture. @anodynos @mlmorg ?

from bower-requirejs.

mlmorg avatar mlmorg commented on June 30, 2024

Backbone.js?

from bower-requirejs.

robdodson avatar robdodson commented on June 30, 2024

@mlmorg perfect, thanks!

from bower-requirejs.

tiger-seo avatar tiger-seo commented on June 30, 2024

also Underscore.js has no bower.json, but has package.json and main in it, though both of them work fine at the moment, since they have main js-file names same way as package, but for example backbone-forms doesn't have bower.json and has no main js-file named as package, so it's simply ignored, though it has main in package.json, which can be used by bower-requirejs to provide path for Require.js

from bower-requirejs.

robdodson avatar robdodson commented on June 30, 2024

This should be addressed by this commit in the postinstall-refactor branch (robdodson/grunt-bower-requirejs@1779f4d). There's a test for backbone-amd which doesn't have a bower.json but does have a package.json which properly specifies the location of the main file. Feel free to PR additional tests if you'd like.

from bower-requirejs.

robdodson avatar robdodson commented on June 30, 2024

Fixed in v0.8.0

from bower-requirejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.