Code Monkey home page Code Monkey logo

Comments (24)

yegor256 avatar yegor256 commented on June 11, 2024 1

@pnatashap maybe you can help?

from 0pdd.

yegor256 avatar yegor256 commented on June 11, 2024 1

@rultor release, tag is 0.31.11

from 0pdd.

yegor256 avatar yegor256 commented on June 11, 2024 1

@rultor stop

from 0pdd.

yegor256 avatar yegor256 commented on June 11, 2024 1

@rultor release, tag is 0.31.11

from 0pdd.

nergal-perm avatar nergal-perm commented on June 11, 2024 1

I've tried it both ways - manually and redelivering last unsuccessful Github webhook. Both gave that response.

I should try to push some commits to master branch and trigger the webhook in "usual" way, though.

from 0pdd.

nergal-perm avatar nergal-perm commented on June 11, 2024 1

@yegor256 , it's all the same, seems that problem is not in the rehttp service.

image

image

from 0pdd.

pnatashap avatar pnatashap commented on June 11, 2024 1

@nergal-perm workaround is to change content-type for webhook to application/json (and can return back rehttp). It will work in both cases, will check what happens with application/x-www-form-urlencoded message type, params are really not parsed

from 0pdd.

pnatashap avatar pnatashap commented on June 11, 2024

rewind is deleted also from rack 3.0, will check for hotfix
rack/rack#1972

from 0pdd.

h1alexbel avatar h1alexbel commented on June 11, 2024

the same

from 0pdd.

pnatashap avatar pnatashap commented on June 11, 2024

fix is merged but not released
@yegor256 may be new release is needed?

from 0pdd.

rultor avatar rultor commented on June 11, 2024

@rultor release, tag is 0.31.11

@yegor256 OK, I will release it now. Please check the progress here

from 0pdd.

rultor avatar rultor commented on June 11, 2024

@rultor stop

@yegor256 OK, I'll try to stop current task.

from 0pdd.

rultor avatar rultor commented on June 11, 2024

@rultor stop

@nergal-perm @yegor256 Sorry, I failed to stop the previous command, however it has the following result: Oops, I failed. You can see the full log here (spent 1hr)

from 0pdd.

rultor avatar rultor commented on June 11, 2024

@rultor release, tag is 0.31.11

@yegor256 OK, I will release it now. Please check the progress here

from 0pdd.

rultor avatar rultor commented on June 11, 2024

@rultor release, tag is 0.31.11

@nergal-perm @yegor256 Oops, I failed. You can see the full log here (spent 3min)

from 0pdd.

yegor256 avatar yegor256 commented on June 11, 2024

@pnatashap I released a new version manually

from 0pdd.

nergal-perm avatar nergal-perm commented on June 11, 2024

@yegor256 , @pnatashap , the result is still 503, but the error text changed:



no implicit conversion of nil into String
	/app/vendor/bundle/ruby/3.1.0/gems/json-2.7.1/lib/json/common.rb:219:in `initialize'
	/app/vendor/bundle/ruby/3.1.0/gems/json-2.7.1/lib/json/common.rb:219:in `new'
	/app/vendor/bundle/ruby/3.1.0/gems/json-2.7.1/lib/json/common.rb:219:in `parse'
	/app/0pdd.rb:359:in `block in <top (required)>'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1804:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1804:in `block in compile!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1071:in `block (3 levels) in route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1089:in `route_eval'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1071:in `block (2 levels) in route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1120:in `block in process_route'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1118:in `catch'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1118:in `process_route'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1069:in `block in route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1066:in `each'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1066:in `route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1190:in `block in dispatch!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `catch'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `invoke'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1185:in `dispatch!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1001:in `block in call!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `catch'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `invoke'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1001:in `call!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:990:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/rewindable_input.rb:25:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/deflater.rb:47:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/xss_header.rb:20:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/path_traversal.rb:18:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/json_csrf.rb:28:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/base.rb:53:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/base.rb:53:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/frame_options.rb:33:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/logger.rb:19:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/common_logger.rb:43:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:266:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:259:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/head.rb:15:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/method_override.rb:28:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:224:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:2115:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1674:in `block in call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1890:in `synchronize'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1674:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rackup-2.1.0/lib/rackup/handler/webrick.rb:111:in `service'
	/app/vendor/bundle/ruby/3.1.0/gems/webrick-1.8.1/lib/webrick/httpserver.rb:140:in `service'
	/app/vendor/bundle/ruby/3.1.0/gems/webrick-1.8.1/lib/webrick/httpserver.rb:96:in `run'
	/app/vendor/bundle/ruby/3.1.0/gems/webrick-1.8.1/lib/webrick/server.rb:310:in `block in start_thread'

from 0pdd.

yegor256 avatar yegor256 commented on June 11, 2024

@nergal-perm new version released, please try again (changes: a627116)

from 0pdd.

nergal-perm avatar nergal-perm commented on June 11, 2024

@yegor256 HTTP code 400, error message is URL-encoded content is expected in the "payload" query parameter, but it is not provided when trying to redeliver last github webhook

from 0pdd.

yegor256 avatar yegor256 commented on June 11, 2024

@nergal-perm this message is a pretty reasonable one. Are you sending this POST request manually or through Github webhook?

from 0pdd.

yegor256 avatar yegor256 commented on June 11, 2024

@nergal-perm if it fails, please attach a screenshot from Github webhooks page

from 0pdd.

nergal-perm avatar nergal-perm commented on June 11, 2024

request headers
response

request payload

Failed.
Screenshots and the payload attached.

from 0pdd.

yegor256 avatar yegor256 commented on June 11, 2024

@nergal-perm as a temporary solution, use this URL for webhook: https://www.0pdd.com/hook/github In the meantime, I will investigate why rehttp doesn't pass the payload through.

from 0pdd.

0pdd avatar 0pdd commented on June 11, 2024

@nergal-perm the puzzle #591 is still not solved.

from 0pdd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.