Comments (4)
Could you point to a concrete example in the tests? Overall, it sounds like a good idea though
from brownie-strategy-mix.
That issue came to me while I tried to write a strategy using the mix and when I realized that harvest will reinvest all the funds and the strategy will be left with nothing.
For example: https://github.com/iearn-finance/brownie-strategy-mix/blob/master/tests/test_operation.py#L13
from brownie-strategy-mix.
That issue came to me while I tried to write a strategy using the mix and when I realized that harvest will reinvest all the funds and the strategy will be left with nothing.
For example: https://github.com/iearn-finance/brownie-strategy-mix/blob/master/tests/test_operation.py#L13
Can you write up a sketch of what the change might look like? (or create a PR)
from brownie-strategy-mix.
Will write the PR
from brownie-strategy-mix.
Related Issues (20)
- Explore importing Integration Test suite using Strategy test suite in Vaults HOT 3
- Bump vaults version to use 0.3.2 HOT 1
- Add as part of test suite a check for handling airdrops of want token on strategy HOT 4
- Upgrade to Vaults 0.3.3
- Add support for solidity 0.8 to sync with vaults PR HOT 4
- Add ethToWant to Strategy.sol
- Make sure _assessFees isn't called twice within the same block
- add liquidateAllPositions
- tests: initialize should take management parameter.
- add matching tags for releases based of yearn vaults repo HOT 1
- fix failing CI in Master HOT 1
- Import deploy script from Yearn-Vaults HOT 8
- Add integration with Tenderly to improve debugging HOT 2
- Not working with ganache v7.0.0-alpha.1 HOT 1
- Cannot add strategy: Contract 'VaultAPI' object has no attribute 'addStrategy' HOT 4
- Readme incorrect for addStrategy arguments HOT 2
- README Instructions Contain Typo
- Accessing Vault via local ABI does not work HOT 9
- README.md instructions for ganache are incorrect. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brownie-strategy-mix.