Code Monkey home page Code Monkey logo

Comments (3)

yd-yin avatar yd-yin commented on August 30, 2024

Hi, thanks for your interest.

The supervised loss in the code is the negative log-likelihood, the same as the paper. It is defined at https://github.com/yd-yin/FisherMatch/blob/main/fisher/fisher_utils.py#L19

Why do you think it is different from the paper?

from fishermatch.

leilai125 avatar leilai125 commented on August 30, 2024

Hi I think I am a bit confused about the code is because it looks a bit different from the function (6) in the paper. What does log_exponent, overreg, log_normalizer represent respectively? I thought loss function will look like: -log(MF(y, A))

I also run the code using this loss function, the return loss is around negative 5. Is this normal? Loss is usually set to be positive (negative is fine as well), just want to double check

I think it might because I am not familiar with fisher matrix distribution. Hope you will provide some explanation to the code here: https://github.com/yd-yin/FisherMatch/blob/main/fisher/fisher_utils.py#L19

Thanks!

from fishermatch.

yd-yin avatar yd-yin commented on August 30, 2024

Given $p(R;A) = \frac{1}{F(A)}\exp(tr(A^TR))$, $-\log(p)=\log(F(A))-tr(A^TR)$, log_normalizer is $\log(F)$, log_exponent is $-tr(A^TR)$. overreg is very close to 1, which is used to better stabilize the training. This term is proposed in [1] (see last paragraph of section 3.2 in [1]) and I leave it as is.

It's normal. $-\log(p)$ will be negative if $p$ is larger than 1. (Note that $p$ is pdf, not probability)

[1] Probabilistic orientation estimation with matrix Fisher distributions. NeurIPS 2020

from fishermatch.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.