Comments (2)
Hi @slemarchand
Yeah, right, all codes are same so far. My initial intention was if some tests needed test dedicated code, (say variations of base.json for different test cases, e.g ) separating them would be beneficial, which is the current implementation.
So, I basically agree with your idea, but I'm still bit concerned. What's your opinion about that part?
from damascus.
Hi @yasuflatland-lf,
Basically, the main disavantage of keeping duplicate templates is that it forces us to synchronize the templates after each modification.
From my point of view, it's better to remove identical templates from the src/test/resources/templates
directory, and to place in this directory only the modified templates for the need of a test case.
from damascus.
Related Issues (20)
- Liferay Logger should be replaced with SLF4J HOT 1
- Application fieldsName should not be required HOT 1
- Is it possible to release compatibility with Liferay Portal 7.3 ? HOT 4
- V1.1.6 - Could not resolve: com.liferay:com.liferay.petra.sql.dsl.api:4.0.0 HOT 13
- Liferay 7.3.3-ce-ga4 - Damascus 1.1.6 - Todo portlet - DocumentLibrary field, upload button, no action HOT 3
- SOLVED - Liferay 7.3.3-ce-ga4 - Damascus 1.1.6 - Todo portlet - Download action - java.lang.ClassNotFoundException HOT 2
- Liferay 7.3.3-ce-ga4 - Damascus 1.1.6 - Todo portlet - 'Move to Recycle Bin' icon, no action HOT 3
- Entities should not all be assets HOT 9
- The PanelApp doesn't point correct jsps for 7.2
- Remove useTP from the template.
- Error creating project, does not find service.xml under api project HOT 10
- Feature request: Modules generation for Liferay 7.4 HOT 2
- View and Update actions fails in portlet deployed in Content Page HOT 2
- Damascus v.1.1.4 fails to create two or more records HOT 4
- Damascus v.V1.1.3 fails in "View" mode with one to many relations model HOT 5
- Error executing damascus create HOT 1
- It is possible to implement columns with multilingual capabilities ? HOT 3
- Impossible to validate two columns with the same relation entity
- It is possible to implement a pull-down list with multiple choice ?
- Support Target Platform HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from damascus.