Comments (6)
from yarnspinner.
Do you mind sharing the yarn spinner extension settings you have currently set? I think there might be a bug with the logic to merge info from .cs
files and commands with "Language": "csharp"
in ysls.json
files (lsp code here). One way to see if that's happening is to change the language on a couple commands from csharp
to text
and check if those commands autosuggest. (I was able to recreate with yarnspinner.CSharpLookup
disabled but wasn't able to pin down if it's a combination of that and other settings)
That error text for wait
is also pretty strange, do you get the correct info text when BuiltInFunctionsAndCommands.ysls.json
is removed?
from yarnspinner.
Do you mind sharing the yarn spinner extension settings you have currently set? I think there might be a bug with the logic to merge info from
.cs
files and commands with"Language": "csharp"
inysls.json
files (lsp code here). One way to see if that's happening is to change the language on a couple commands fromcsharp
totext
and check if those commands autosuggest. (I was able to recreate withyarnspinner.CSharpLookup
disabled but wasn't able to pin down if it's a combination of that and other settings)That error text for
wait
is also pretty strange, do you get the correct info text whenBuiltInFunctionsAndCommands.ysls.json
is removed?
First, thank you for your help! I really appreciate it.
I've got no extension settings set. I just tried a fresh install of VS code on a new machine (using ninite.com for the installer) with no settings set in VS Code or the extension. I installed the yarn spinner extension v2.2.106, then created a simple Test.yarn file and the wait command was not recognized. Is a yarnproject file required for a .yarn file to get command definitions?
I will try playing with the language types but I've not seen any sign that any ysls is being loaded. Could you maybe add a log to the extension log when a ysls file is loaded.
from yarnspinner.
Here's a view of the Yarn Spinner output.
from yarnspinner.
Thanks for the additional info, that narrows things down considerably! One other thing to check, are you opening individual files or are you opening a folder?
I'm able to recreate when I make individual files directly. The error handling / logging could be updated to make this more obvious but most of the language server features depend on a folder/workspace being available (code where it gives up if that's the case).
(comparison screenshot of file vs folder)
from yarnspinner.
This is fixed as a result of 205e32b, 86a3c32, and 611c07a.
Basically:
- If the workspace had no root folder, a bug caused the language server to not check any action definitions, including built-in Yarn commands like
wait
. - Now, if the workspace has no root folder, we still don't have a way to go looking for your C#-defined actions or your .ysls.json files, so 205e32b now shows a warning to the user and offers a fast way to resolve the issue (by opening a project folder.)
Thanks for the issue and for the discussion, all!
from yarnspinner.
Related Issues (20)
- It is possible to sneak empty or whitespace-only commands past the compiler
- `TestLineTagsAreAdded` depends on dictionary order, which is not guaranteed HOT 1
- Proposal: Options that disappear and fallback. HOT 6
- Effects.Typewriter fails when TimeScale is 0 HOT 1
- Variables corrupted (in some locales) when calling Custom Commands with float arguments HOT 2
- .ysls.json no longer read in VS Code with extension v2.2.119 HOT 1
- Running `ysc tag` appears to de-escape `\\` to just `\` HOT 2
- Proposal: Smart Variables HOT 5
- Proposal: Decide on string interpolation rules for lines and commands
- Fully qualified yarn commands don't get detected by the LSP HOT 1
- Unexpected "[" while reading a shortcut option statement HOT 1
- yarn function comments are being truncated to the first line HOT 1
- C# command registration uses argument as literal rather than resolved value HOT 3
- Proposal: Multi-line comments HOT 1
- Empty nodes are included in the compiled output
- TryGetValue<T> called with type IConvertible. HOT 1
- Variable declaration inference breaks on certain sets
- Some built in functions are saying they return any instead of their appropriate return type in the LSP
- empty nodes create a weird error message from the LSP
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yarnspinner.