Code Monkey home page Code Monkey logo

Comments (7)

Yaribz avatar Yaribz commented on June 9, 2024

I started implementing this, but if I understand correctly the lobby server will only send the KICKFROMBATTLE command if the client is in a battleroom while being kicked from lobby server. So basically one would just need to leave the battleroom as soon as the game has started to protect himself from being kicked from game by lobby server?

from spads.

silentwings avatar silentwings commented on June 9, 2024

You're right, I realized this issue as well - in future the lobby wil simply remember the most recent battle client was in and send the battle_id of that one, but I haven't implemented it yet.

from spads.

Yaribz avatar Yaribz commented on June 9, 2024

I'm not sure the battle_id parameter is really needed actually. I think SPADS will just ignore it because it's entirely possible that the battle lobby has been rehosted (thus changing the battle ID) while a game is in progress and SPADS doesn't keep previous battle IDs in memory.
Basically when SPADS receives a KICKFROMBATTLE command it will just check that a game is in progress and userName is allowed to connect to this game (he can be already connected or not yet connected). Only in this case it will perform a one-game kickBan for this user.

from spads.

silentwings avatar silentwings commented on June 9, 2024

The battle_id is only included in preparation for a future version of the protocol, not planned any time soon, which could allow users (& particularly match-making autohosts) to be present in multiple battles at once. Ignoring it is fine.

from spads.

Yaribz avatar Yaribz commented on June 9, 2024

You mean there could be cases where a player is in two games hosted by same autohost simultaneously and an admin could want to kickban this player from one game but not from the other one ?

from spads.

silentwings avatar silentwings commented on June 9, 2024

I appreciate it would be a bit odd to want that particular thing - but essentially yes .. perhaps. I'm sticking to a general principle that (new) protocol commands relating to battles should specify which battle they relate to.

from spads.

Yaribz avatar Yaribz commented on June 9, 2024

implemented in SPADS 0.12.5 ( 2cab8ef )

from spads.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.