"_unknown" uri passed for POSTs to signalfx about node-measured HOT 7 CLOSED

On further investigation, it looks like both the uri dimension and the status code issue are resolved by using res.on('finish', () => { instead of req.on('end', () => {
Happy to make a PR unless this is just some quirk in my setup.

from node-measured.

from node-measured.

from node-measured.

Created an integration test to show the failure... but it actually works 😮
#59

The cause appears to be app.use(express.json()). If (and only if) I don't pass a Content-type express.json() is listening to, the dimensions come through properly.

from node-measured.

I saw that the build for #58 is failing, I assume you are going to work through that and update your PRs to get this issue closed?

from node-measured.

I have the fix for the failing build, but was holding off until I was able to produce an integration test that actually showed the issue. I now have, you can see it here: https://github.com/avolfson/node-measured/compare/master...avolfson:avolfson-patch-57-it?expand=1 & avolfson@31aeae8

This failing test requires use of express.json() as a middleware. @fieldju, do you consider this valid? If so, I'll add it to the PR with the fix & unit tests as well. Appreciate any other feedback as well.

from node-measured.

Closed by #59

from node-measured.