Comments (7)
On further investigation, it looks like both the uri dimension and the status code issue are resolved by using res.on('finish', () => {
instead of req.on('end', () => {
Happy to make a PR unless this is just some quirk in my setup.
from node-measured.
from node-measured.
from node-measured.
Created an integration test to show the failure... but it actually works 😮
#59
The cause appears to be app.use(express.json())
. If (and only if) I don't pass a Content-type express.json()
is listening to, the dimensions come through properly.
from node-measured.
I saw that the build for #58 is failing, I assume you are going to work through that and update your PRs to get this issue closed?
from node-measured.
I have the fix for the failing build, but was holding off until I was able to produce an integration test that actually showed the issue. I now have, you can see it here: https://github.com/avolfson/node-measured/compare/master...avolfson:avolfson-patch-57-it?expand=1 & avolfson@31aeae8
This failing test requires use of express.json() as a middleware. @fieldju, do you consider this valid? If so, I'll add it to the PR with the fix & unit tests as well. Appreciate any other feedback as well.
from node-measured.
Closed by #59
from node-measured.
Related Issues (20)
- Is it possible to enable and disable the metrics through configurations? HOT 1
- toJSON() is named incorrectly - doesn't return JSON HOT 1
- Unbounded memory usage HOT 12
- Histograms - possible to show windowed averages HOT 5
- Cannot use EWMA with Histogram HOT 2
- Histogram - quantiles weighting HOT 1
- How to use this with Graphite? HOT 2
- Create Type File for Typescript compatibility HOT 5
- Decide whether or not this should be hard forked or add new maintainers. HOT 1
- Support for Value and Rate in Histogram HOT 5
- The return value of funtion:SettableGauge.getType is difference from the requested Type in funtion:Collection.settableGauge. HOT 1
- Object.values is not a function on Nodejs 6.9.0 HOT 1
- bunyan dependency on dtrace-provider is problematic HOT 3
- docs: document release process HOT 5
- Why isn't DimensionAwareMetricsRegistry a subclass of Collection? HOT 5
- Re-hydration from previous state HOT 2
- Get max value of a counter - Feature request (or potentially stupid user) HOT 2
- [RFC] 3.0? HOT 12
- "measure-node-metrics" package is missing Koa middleware support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-measured.