Comments (11)
@velikanov I share your sentiment. Can't open an issue though
from swiftpasscodelock.
@waltermvp, excuse me, I thought that GitHub clones all repository structure automatically
it's done now, you can create new Issues
I'll try to migrate all old open issues
from swiftpasscodelock.
@velikanov I agree, let's keep this project live.
We are actively using this library in an app and we are really happy.
I have add, some more functionality but in separate classes in my project.
I really find handy, that @yankodimitrov decided in the refactor to keep the PasscodeRepository as a protocol and not make it part of the project.
We have also added exponential backoff on failed PIN attempts + a dummyView for app is in background. ;)
Let me know if you want me to share some tips on this.
from swiftpasscodelock.
@yankodimitrov if you like the idea you can add us as contributors so as we can help you and we keep this nice repo, instead of another fork
from swiftpasscodelock.
@yankodimitrov I recently saw that you have accepted a PR. Will we keep this repo active? Shall we continue making our PR's to your repo?
This is your work man and you have done very good work so far, so please update us if we can help you to keep this project rolling.
from swiftpasscodelock.
First thank you all for your pull requests and support!
You can continue to send pull requests. Im a bit busy right now but will try to look at the repo.
Furthermore @ziogaschr and @velikanov let me know if you want me to add you as collaborators.
Thanks!
from swiftpasscodelock.
Thank you for the update @yankodimitrov.
It's up to you to add us as collaborators. :)
Do you find a good idea to merge the latest changes from @velikanov master? As it is harder to re-create all PRs. Let us know if you prefer PRs
from swiftpasscodelock.
@yankodimitrov I tried to add new PR's although, because the base of what I currently use is from @velikanov master branch the PR had more stuff in it.
Is it ok with you to create a PR with all the changed things at @velikanov master branch so as we sync them and then add two new PRs velikanov#15 and velikanov#16 so as we can continue with your repo?
from swiftpasscodelock.
@ziogaschr need to use this repo again. I'm assuming your fork is the best option to move forward? Also would using "PasscodeLock" for cocoapods give me your fork? if not how would i add your fork using cocoaopods?
from swiftpasscodelock.
Yes. I have updated the Swift3 branch on my repo this week, but I want to check some stuff till monday in order I merge it with my repos' master.
I would like to help closing all the issues, although every time I am trying to do this I have to merge all changes from main repo + @velikanov which is such a pain
Sent from my iPhone
On 18 Nov 2016, at 21:09, Walter Martin Vargas-Pena <[email protected]mailto:[email protected]> wrote:
@ziogaschrhttps://github.com/ziogaschr need to use this repo again. I'm assuming your fork is the best option to move foward?
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/29#issuecomment-261615211, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAw_jJvLQGKwi2xI2qPMuaDaAbkTcP1Kks5q_ff2gaJpZM4G4Z3M.
from swiftpasscodelock.
Hmm I can imagine. Here to help :)
from swiftpasscodelock.
Related Issues (20)
- Troy
- Cannot display passcode on app open with SceneDelegate
- Iphone 6 and Iphone 6S dots and keypad not increase their size
- Swift 3 Update :D HOT 11
- Swift 2.3 update? HOT 1
- PasscodeLock App Delegate preventing SVProgressHUD from showing HOT 1
- Support both passcode and TouchID at the same time like iphone passcode lockscreen HOT 2
- Carthage build issue on swift 3.1 HOT 5
- Pre-set password? HOT 1
- App rejected with passcode lock HOT 3
- Can I pass segue from passcode viewController? HOT 5
- UI looks of SwiftPasscodeLock will get your app rejected from the app store HOT 3
- Landscape mode not supported
- Swift 4 HOT 3
- Simultaneous accesses to *, but modification requires exclusive access HOT 8
- crash when set password HOT 2
- Not maintained? HOT 2
- T
- New
- Perforce branch might be sync'ed multiple times with different
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swiftpasscodelock.