Code Monkey home page Code Monkey logo

Comments (9)

ziogaschr avatar ziogaschr commented on September 15, 2024

I think this is because the passcodeLockPresenter is lazy initiated without touchID support on first app launch. I was able to handle that by making the passcodeViewController public and then changing its properties from the app while Passcode is set.

I can add an example on this @gblotter if you want. But I was thinking that @yankodimitrov will handle this in the swift-2.0 branch differently.

from swiftpasscodelock.

yankodimitrov avatar yankodimitrov commented on September 15, 2024

Could someone test for that on the new version?

Thanks!

from swiftpasscodelock.

gblotter avatar gblotter commented on September 15, 2024

So here is what I'm seeing:

Same behavior that I originally described. Additionally, once the passcode is set, kill the app. Open the app and the TouchID authentication is presented. Hit the home button, go into the app again, and now just the passcode, no TouchID authentication is presented.

Of course in each of these scenarios you can tap the 'Use TouchID" button to bring it up. I'm just not sure if that is your intended behavior.

from swiftpasscodelock.

yankodimitrov avatar yankodimitrov commented on September 15, 2024

It seems that this is the intended behaviour by the system:

LAErrorSystemCancel

Authentication was canceled by system—for example, if another application came to foreground while the authentication dialog was up.

from swiftpasscodelock.

gblotter avatar gblotter commented on September 15, 2024

Right... I believe that just means that it needs to be implemented differently, i.e. when the applicationDidEnterBackground() method is called, it's throwing up the passcode lock screen. Somehow the applicationWillEnterForeground() method need to be used?

I know that other apps do it just fine... BUT... Those are just my thoughts. If this is "good enough" for now, that's cool. You're the author, designer, and decision maker :)

from swiftpasscodelock.

yankodimitrov avatar yankodimitrov commented on September 15, 2024

I have never said that it is good enough. As currently I cannot test on a device with TouchID it is somehow hard for me to fix the issue and I will leave it open for now. Also any PRs are welcome.

from swiftpasscodelock.

ziogaschr avatar ziogaschr commented on September 15, 2024

@yankodimitrov this is why I have moved some of the logic in the old project in applicationWillEnterForeground. When I will install Swift 2.0, I will try to suggest a PR.

from swiftpasscodelock.

yankodimitrov avatar yankodimitrov commented on September 15, 2024

Could someone test my latest commit (not the latest release) with the TouchID request fix on a device with TouchID?

If everything is working properly I will publish a new release.

Thanks!

from swiftpasscodelock.

yankodimitrov avatar yankodimitrov commented on September 15, 2024

The new simulator found in Xcode 7 GM can simulate TouchID authentication. Just tested and fixed the issue.

Check out the release version 1.0.1

Thanks!

from swiftpasscodelock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.