Code Monkey home page Code Monkey logo

Comments (7)

SpacedOutChicken avatar SpacedOutChicken commented on May 21, 2024

Just to clarify, the Medical Network requires a Hospital in at least four cities. I think that requirement should be displayed underneath it, explaining why it can't be built.

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on May 21, 2024

Analyis... Compare RequiresBuildingInAllCities with RequiresBuildingInSomeCities - as UniqueType and almost-identically-named RejectionReasonType. I see no dissymmetry anywhere... Except in orderedImportantRejectionTypes. That will be 'it' most likely.

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on May 21, 2024

But - IConstruction.kt somehow really calls for a reorg. It's got six top-level declarations that should be each their own file (or nested), and those four RejectionReasonType collections in RejectionReason are - on the third or fourth look - a catastrophe. They're instantiated anew for each new RejectionReason, despite being static in nature. Oversight wouldn't have happened if the usecases were implemented as enum properties on the type - makes the enum instances a little longer, but all uses much shorter and more efficient...

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on May 21, 2024

Also, there's no Medical Network in the public Deciv Redux.

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on May 21, 2024

Faking the unique on the next best victim and patching orderedImportantRejectionTypes as stated above I can get:

image

from unciv.

SpacedOutChicken avatar SpacedOutChicken commented on May 21, 2024

Also, there's no Medical Network in the public Deciv Redux.

https://github.com/SpacedOutChicken/DeCiv-Redux/blob/0bf8d55beae75c1912a2095ebca02e7e2bb210bb/jsons/Buildings.json#L1721

This is likely to change soon, once Sullien updates the mod, but it's there right now.

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on May 21, 2024

there right now

I admit I just used the built-in mod manager, looking for date and update, then pedia... Strange as github blame says that line is a year old. But as you can see further down I just created the situation elsewhere.

from unciv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.