Exception in Rust code bringing the entire dotnet server down about ydotnet HOT 5 OPEN

@SebastianStehle I spent some time reading about it, and it seems that it is not possible to handle panics the way YDotNet have implemented it. It would require it to run in a separate process or similar :(

Also, the issue I am facing seems quite hard to reproduce. I only saw it happen once. If I am able to consistently reproduce I will try to investigate. Thanks for all the help!

from ydotnet.

Unfortunately not. It is one of 2 errors:

1. A panic in rust.
2. A null pointer.

We are working to solve the second problem with smart pointers, but it is still unsolved. Usually you cannot log anything anymore, when this happens. This also sucks.

from ydotnet.

We're working on this on Rust side and should be able to show some improvements regarding invalid pointers soon.

from ydotnet.

I might try to fix the panic in rust issue then. Not sure if it is possible to fix that tho, but maybe just add some code to the way we call the rust binaries to catch panics and prevent the pod from going down.

How does ydotnet interact with Rust binaries? Is there any documentation I could read on the topic?

from ydotnet.

I think it is not possible, because a panic is basically a process.exit(ERROR) in Dotnet. But I would be happy if you could solve that.

There is no documentation, but this is how it works:

1. Y-crdt has a C binding layer: https://github.com/y-crdt/y-crdt/tree/main/yffi that is used for that.
2. In out native namespace we have all the code to talk with the channels: https://github.com/y-crdt/ydotnet/blob/main/YDotNet/Native/Document/DocChannel.cs#L15
3. Sometimes we have to follow pointers, then we always do that in the Native namespace, e.g. here: https://github.com/y-crdt/ydotnet/blob/main/YDotNet/Native/Document/Events/SubDocsEventNative.cs#L21
4. We expose CLR types that are converted from the native types. The conversion is done outside of the native namespace. The goal is to have a dependency to the native namespaces but not from this namespace to avoid a circular dependency hell. See: https://github.com/y-crdt/ydotnet/blob/main/YDotNet/Document/State/DeleteSet.cs#L10

from ydotnet.