Comments (4)
tooolbox
commented on May 18, 2024
1
Also seems to break setting cookies such as the username cookie.
I'm wondering if we're using httptest.ResponseRecorder incorrectly. We are accessing its HeaderMap but the docs say that field is deprecated and you should use recorder.Result().Header instead. I'll try it out.
from algernon.
xyproto
commented on May 18, 2024
Yes, this is an issue.
from algernon.
tooolbox
commented on May 18, 2024
I believe having debug mode also breaks setheader().
from algernon.
tooolbox
commented on May 18, 2024
Alright, the problem is calling w.WriteHeader before copying the headers. Per the docs, Changing the header map after a call to WriteHeader (or Write) has no effect unless the modified headers are trailers.
I don't really get why there's a FutureStatus since we're buffering the HTTP responses anyway. Hm, I suppose when debug mode is off, there's no buffering.
I'll put together a PR but I'd like you to look at it @xyproto before I merge it since it will potentially affect parts of the system I haven't grokked yet.
from algernon.
Related Issues (20)
- pug and jade template support HOT 6
- %2F in URL
- low ulimit on macOS HOT 1
- Lua tables that contains objects are not rendered with pongo2 HOT 13
- Authrefresh crashes randomly at startup HOT 2
- Command line arg --internal=filename ignores filename HOT 3
- Can Algernon be configured to run over SSL but with a self-signed cert
- ability to close the response stream early HOT 5
- Integrate pure-go Svelte compiler just like plenti HOT 7
- gopherlua doesn't support package.loadlib HOT 3
- MultiMarkdown CriticMarkup Support
- lua to wasm HOT 2
- .alg files are persisted to /tmp HOT 2
- sqlite support HOT 2
- examples for data validations
- Create more documentation and learning materials (like tutorial + reference) HOT 7
- Vhost handling HOT 1
- Automatic ACME / LetsEncrypt HOT 4
- Unable to serve files with embedded new line HOT 2
- Algernon flags precedence issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from algernon.