Homebrew 3.1.2 upgrade issue about cash-cli HOT 20 CLOSED

One thing you should do is to rename the commit and PR title as cash-cli: 3.1.2, and we are good to go. 🎉

from cash-cli.

I could remember the details, but it might be because i was just using your suggestion in 3.1.0, and now we are in 3.1.2. I will try to see if it works in my local though.

from cash-cli.

yeah, it works in my local too.

from cash-cli.

@chenrui333 done 😄

from cash-cli.

Hi @chenrui333, sorry for the delay, but I was on holiday in Spain this week ;)

In 3.1.0 I added the API key validation, so the output of cash --key foo is now: Provided API key seems invalid, please try again! and not: 'Saved API key to [...]. To fix that, we can either change this line to:

assert_match "Provided API key seems invalid, please try again!"

or we can change the test command from cash --key foo to something like cash --key 11111111111111111111111111111111 and keep assert_match the same as before.

Let me know which option is better and I will open a pull request to the Homebrew repo 😄

from cash-cli.

cool, welcome back!

I am outside now, I will check later tonight or tomorrow. Thanks for checking on this!

from cash-cli.

Sorry for trying this late. It seems still not quite working.

I have directly called the command and get the following output:

$ /usr/local/Cellar/cash-cli/3.1.0/bin/cash --key 111111111111111111111111111111
/usr/local/Cellar/cash-cli/3.1.0/libexec/lib/node_modules/cash-cli/node_modules/conf/index.js:58
				throw new Error('Project name could not be inferred. Please specify the `projectName` option.');
				^

Error: Project name could not be inferred. Please specify the `projectName` option.

from cash-cli.

It also looks like there is no help cli option:

$  /usr/local/Cellar/cash-cli/3.1.0/bin/cash help
/usr/local/Cellar/cash-cli/3.1.0/libexec/lib/node_modules/cash-cli/node_modules/conf/index.js:58
				throw new Error('Project name could not be inferred. Please specify the `projectName` option.');
				^

Error: Project name could not be inferred. Please specify the `projectName` option.

from cash-cli.

Could you try it with the newest 3.1.1 version? Something was wrong with the conf module, but it's now updated, so everything should be working fine 😄

from cash-cli.

Definitely, doing it now.

from cash-cli.

Still had the same issue:
https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/44232/version=mojave/console

06:40:22 ==> /usr/local/Cellar/cash-cli/3.1.1/bin/cash --key foo
06:40:22 /usr/local/Cellar/cash-cli/3.1.1/libexec/lib/node_modules/cash-cli/node_modules/conf/index.js:58
06:40:22 				throw new Error('Project name could not be inferred. Please specify the `projectName` option.');
06:40:22 				^
06:40:22 
06:40:22 Error: Project name could not be inferred. Please specify the `projectName` option.

from cash-cli.

@xxczaki ping. :)

from cash-cli.

@chenrui333 Ouch, I totally forgot about that! Well, after investigating this issue I realised, that adding a projectName to conf module options should fix our problem.

Just published 3.1.2 😄 Let me know if everything works now (and if not I will open an issue in the conf repository).

from cash-cli.

Sorry! Accidentally closed it 😆

from cash-cli.

cool!, will try the new one, cheers!

from cash-cli.

@xxczaki Still failed :( (build ref: https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/44594/version=mojave/console)

07:21:13 ==> /usr/local/Cellar/cash-cli/3.1.2/bin/cash --key foo
07:21:13 Error: cash-cli: failed
07:21:13 An exception occurred within a child process:
07:21:13 Test::Unit::AssertionFailedError: <0> expected but was

from cash-cli.

Hmm, error message doesn’t make much sense. Will look at it later today.

from cash-cli.

@chenrui333 Hi, I created a pull request in the Homebrew/homebrew-core repository with changes I suggested in #30 (comment) . It passed the test.

I have no idea why it wasn't working when you tried it in the console.

What should we do?

from cash-cli.

that is cool!! I will close my PR in favor of yours. :)

from cash-cli.

Thanks a lot!! Closing my issue now.

from cash-cli.