Comments (5)
@cherio the vfb code knows nothing about authentication modules, and the authentication modules know nothing about the command line.
Please try e1b5660
from xpra.
It's not easy to decide which variables should be sanitized and which ones should not be.
The safe approach is to only use a whitelist, but this is bound to break something, somewhere.
I would recommend using a different authentication module instead.
Otherwise, please submit a PR.
from xpra.
I may be missing something but wouldn't it be safe to assume that the variable whose name referenced as --auth=env:name=VAR
should be removed from the environment?
from xpra.
I'm not going to do this sorts of parsing gymnastics, sorry.
from xpra.
I was just responding to
It's not easy to decide which variables should be sanitized
simply pointing to the fact that the variable name that holds authentication password is readily available, as it is explicitly specified. I realize that because I am not familiar with the code, what seems to be obvious and simple on the surface, may not really be that straightforward.
from xpra.
Related Issues (20)
- Opening "Session Info" while "server is not responding, drawing spinners over the windows", can lead to timeout HOT 15
- Xpra Client not reconnecting after Update to Version 12 HOT 7
- App tray icon didn't show on windows HOT 3
- When using HiDPI, in Ghidra, some window content is not scaled up but some are HOT 4
- Distortions to remote windows after update HOT 19
- make it easier to setup a development environment HOT 1
- make it easier to install the xpra.org repositories HOT 1
- VirtualBox context menus disappear HOT 11
- openh264 encoder error `codec bitstream size is larger than Level limitation` HOT 1
- preserve file order when matching content type mappings
- sometimes Xpra keeps on starting Xvfb-for-Xpra processes endlessly HOT 7
- --without-http broken in 6.0.1 HOT 3
- impossible to access xpra repos HOT 2
- xpra attach from wayland to x11: "connection timed out" HOT 4
- shadow mode @ wayland client: content drawn to just 1/4th of window size HOT 3
- docs: Usage/Desktop.md not found HOT 4
- Dead link / Redundant wiki page HOT 1
- [v5.0.9-r0] TypeError: 'type' object is not subscriptable HOT 2
- PEP 517 wheel build is broken since 6.0 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xpra.