Code Monkey home page Code Monkey logo

Comments (29)

tablatronix avatar tablatronix commented on July 17, 2024 4

At first I thought it was tft_espi, but that will not have the offset defines in it yet.

I found this though, which seems to be a non forked clone ( why!!!!! what is so hard about forking and PR your changes ? )

https://github.com/REVOtic/TFTDriver

https://github.com/REVOtic/TFTDriver/blob/master/TFT_Drivers/ST7789_Rotation.h#L34

#ifdef TTGO_114_INC_DISPLAY
      colstart = 53;
      rowstart = 40;
  #else
       colstart = 0;
       rowstart = 80;
  #endif

from ttgo-t-display.

Bodmer avatar Bodmer commented on July 17, 2024 4

TFT_eSPI has been updated to include offsets for this display. A new user setup file has been added to show the setup used for testing.

from ttgo-t-display.

lewisxhe avatar lewisxhe commented on July 17, 2024 3

digitalWrite(TFT_BL, 0); @auculab

from ttgo-t-display.

lewisxhe avatar lewisxhe commented on July 17, 2024 1

I can of course add it. Small meaning. @SuperEugen

from ttgo-t-display.

lewisxhe avatar lewisxhe commented on July 17, 2024 1

@kalyan540 Please manually refresh the firmware in the warehouse to eliminate hardware problems.

from ttgo-t-display.

Nufflee avatar Nufflee commented on July 17, 2024

@tablatronix That actually does work perfectly! Thank you so much!

from ttgo-t-display.

Nufflee avatar Nufflee commented on July 17, 2024

Actually @LilyGO @lewisxhe you should fix the README.

from ttgo-t-display.

cyraxx avatar cyraxx commented on July 17, 2024

Looks like the repo linked in the README now includes the proper defines. It works fine for me (after enabling the correct User_Setup).

from ttgo-t-display.

TotallyInformation avatar TotallyInformation commented on July 17, 2024

@cyraxx I've just tried the version in the README and it does not work - see Issue #4

The REVOtic library works perfectly.

OK, now I see that the README references a FORK of the TFT_eSPI library rather than the original. That fork is 96 commits behind current. So clearly not being maintained very well. That is crazy - why not just submit a PR back to the original to get the correct settings included?

I'm guessing that, while it works, the REVOtic library is probably even worse since it doesn't even reference the original it was based on.

What a pain. I can't see myself buying any more LilyGO hardware if this is the quality of support.

from ttgo-t-display.

cyraxx avatar cyraxx commented on July 17, 2024

Yup, both of the libraries referenced in README are actually forks.

I didn't check whether their fork or the REVOtic one is more current but they do both include the offsets needed for this board.

from ttgo-t-display.

TotallyInformation avatar TotallyInformation commented on July 17, 2024

This is what the readme says:

Move or copy User_Setups/TTGO_T_Display.h to TFT_eSPI/User_Setups/

But that source does not exist in this repo nor in the fork. So the README needs to be at least updated.

I've tried using the original TFT_eSPI library and I can nearly get it working correctly. However, the offsets are clearly not quite right somewhere because some of the original bitmap still shows to the right of the screen (about a 1/3 of the right-hand-side).

I'll look at it again tomorrow if I have time and if I can work it out, I'll raise an issue with Bodmer's repo.

from ttgo-t-display.

cyraxx avatar cyraxx commented on July 17, 2024

Move or copy User_Setups/TTGO_T_Display.h to TFT_eSPI/User_Setups/

But that source does not exist in this repo nor in the fork. So the README needs to be at least updated.

The source file actually is in this repo but the path in the README is wrong - it's in the root directory, not in User_Setups. Copying that file into the lewisxhe fork of TFT_eSPI (and editing User_Setup_Select.h to include it) made it work for me.

BTW I found this issue in Bodmer´s repo: Bodmer/TFT_eSPI#379 I think that's the same screen.

from ttgo-t-display.

lewisxhe avatar lewisxhe commented on July 17, 2024

Yes, the referenced TFT_eSPI is the branch that I modified after the fork. I should describe it clearly in the readme. Thank you for your reminder.

from ttgo-t-display.

TotallyInformation avatar TotallyInformation commented on July 17, 2024

Well, I've looked again but there are too many differences between the libraries for me to work it out. I'll raise an issue in Bodmer/TFT_eSPI though to see if someone with better understanding than me can add T-Display support to the original library. Oops, I should have checked, Issue #379 has already been raised.

I still can't work out how the offset works even though I've changed the entries in the TFT_Drivers folder to include the rotation (and other) changes.

Drat, wasted some time there. You also need to set the define for CGRAM_OFFSET in TFT_Drivers/ST7789_Defines.h.

So, with the simple tweaks to the original library, you can use it just fine. Hopefully, Bodmer will be able to update soon.

Also I note that you have to manually turn on the backlight so you need to add that code to the setup function of the Bodmer/TFT_eSPI repo examples.

from ttgo-t-display.

tablatronix avatar tablatronix commented on July 17, 2024

The backlight is IO4 NOT IO14 as the graphic on the readme says!

from ttgo-t-display.

lewisxhe avatar lewisxhe commented on July 17, 2024

The library used has been synchronized to the main branch

from ttgo-t-display.

SuperEugen avatar SuperEugen commented on July 17, 2024

I added the following two lines to the TTGO_T_Display.h file and can now use the examples from the original TFT_eSPI library from @Bodmer :

#define TFT_BL 4
#define TFT_BACKLIGHT_ON HIGH

@lewisxhe can you add these lines to the .h file?

from ttgo-t-display.

Joennuh avatar Joennuh commented on July 17, 2024

It is the best to handle that in your main sketch since the pin on which the led backlight is connected is capable of PWM. Defining an on or off state in header file could lead to issues to set the backlight intensity.
And besides that: the example sketch already turns the backlight on on line 135: https://github.com/Xinyuan-LilyGO/TTGO-T-Display/blob/master/TTGO-T-Display.ino#L135

from ttgo-t-display.

Bodmer avatar Bodmer commented on July 17, 2024

Defining the backlight pin and level in the setup file does not affect the ability to use PWM later in the sketch. The pin is only set during the init() function.

The point of defining the pin in the setup file is that all the existing TFT_eSPI examples can then be run without modification.

from ttgo-t-display.

lewisxhe avatar lewisxhe commented on July 17, 2024

The reason I define it in the sketch is to let everyone know the pin behind it. I feel that this is not a big problem.

from ttgo-t-display.

auculab avatar auculab commented on July 17, 2024

Hello, can you pls request your support on how to turn off the backlight of TTGO T-Display. I want to turn off the display backlight after a timeout to be able to conserve battery if not being used and bring back at the press of button 2. I'm unable to find how to reverse this.

     digitalWrite(TFT_BL, TFT_BACKLIGHT_ON); 

Thank you

from ttgo-t-display.

kalyan540 avatar kalyan540 commented on July 17, 2024

Pls help me the TTGO-TDisplay won't display anything after I upload a new code TTGO_T-Display.ino,and I follow instructions in readme.md,could any one rectify my problem.

from ttgo-t-display.

kalyan540 avatar kalyan540 commented on July 17, 2024

@lewisxhe Thanku for your reply
If my problem is not solved then I reply ones.

from ttgo-t-display.

lewisxhe avatar lewisxhe commented on July 17, 2024

@kalyan540 If that doesn't work, please contact customer service and provide a video

from ttgo-t-display.

kalyan540 avatar kalyan540 commented on July 17, 2024

@lewisxhe it is working but not displaying anything ,it shows in serial monitor(voltage, WiFi networks), and it is a new one, before uploading it displays (like brand and voltage....)but after uploading TTGO.....ino only backlight is glowing ... What should I do now..?

from ttgo-t-display.

lewisxhe avatar lewisxhe commented on July 17, 2024

Sorry, it should be the screen is damaged, please contact customer service

from ttgo-t-display.

kalyan540 avatar kalyan540 commented on July 17, 2024

@lewisxhe Thanku for your reply
It is working with Adafruit_ST7789.h along with Adafruit_GFX.h library functions, I think code has some errors, pls do any changes, and I got an error msg " TFT_BACKLIGHT_ON was not declared in this scope " Thanku.

from ttgo-t-display.

lewisxhe avatar lewisxhe commented on July 17, 2024

@kalyan540
Define a macro directly
` #define TFT_BACKLIGHT_ON 1 `
Or directly change TFT_BACKLIGHT_ON to 1

from ttgo-t-display.

kalyan540 avatar kalyan540 commented on July 17, 2024

@lewisxhe Thanks for your reply

#define TFT_BACKLIGHT_ ON  HIGH //it is working (Backlight on)

But the TFT_eSPI.h library function is not working for my ttgo t-display ,and I followed the instructions in Readme.md
Pls show me a way to work with this library .

from ttgo-t-display.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.