Code Monkey home page Code Monkey logo

Comments (4)

xingyizhou avatar xingyizhou commented on August 29, 2024

Hi,
Thanks for reading the code,
A) Yes, keeping the 3D aspect ratio is all this segment of code about.
B) Note that pts is the GT 2D keypoint annotation. The goal of the last three line is to align the weakly-perspective projected 3D joints with the 2D annotation. I.e., if you plot pts_3d[:, :2] to image, you will find they are very close to pts.
C) I didn't understand the question. See the \hat{Y} equation at 5th page middle right column in the paper.
D) To keep z in range (0 ~ 256) as (x, y), actually it is not necessary for that it is re-normalized to -1 ~ 1 in https://github.com/xingyizhou/pytorch-pose-hg-3d/blob/master/src/datasets/h36m.py#L76, you can remove both lines for simplicity (I haven't tried).

from pytorch-pose-hg-3d.

bloodymeli avatar bloodymeli commented on August 29, 2024

Hi,

Thanks for the prompt response.
I have to admit that I'm confused by lines 58 and 76 in h36m.py, and line 38 in FusionCriterion.py.
If x,y,z are the true coordinates, is the output of the network trained to be 2 * (x,y,z) / output resolution?
Why use this calibration choice?

from pytorch-pose-hg-3d.

xingyizhou avatar xingyizhou commented on August 29, 2024

Hi,
A very detailed explanation of why/how to use this calibration can be found in Section 3.2 of https://arxiv.org/pdf/1803.09331.pdf .

from pytorch-pose-hg-3d.

FANG-Xiaolin avatar FANG-Xiaolin commented on August 29, 2024

Hi Xingyi,
I think neither https://github.com/xingyizhou/pytorch-pose-hg-3d/blob/master/src/datasets/h36m.py#L76 nor https://github.com/xingyizhou/pytorch-pose-hg-3d/blob/master/src/datasets/h36m.py#L58 will keep z in a specific range like (0 ~ 256) or (-1 ~ 1). As an extreme example, we can think about two points that have the same x and y value while one of them is extremely far away and has a very big z value.
But it will do no harm to the final result since the ratio is kept all the way.

from pytorch-pose-hg-3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.