Comments (2)
Double-Checked Locking may not work
is right, which usually may because the new Table
actually isn't atomic
operation and the step of construct
may be re-order
under compiler optimization, so that the table != null
but may not be complete object
(for example, it's field may have not be inited base user setting). So volatile
can forbid the re-order
and is used for resolving the case widely.
If my understand is right, and then:
- Firstly,
volatile
can't be allowed to be used aslocal variable
, so I think the solution isnβt appropriate if the code was wrong. - Secondly,
table
is local variable, every thread will create own copy variable, and put theConcurrentHashMap
after thetable
is complete inited, So it shouldn't happen the case: put oneincomplete
table object intoConcurrentHashMap
and obtain by another thread.
So the code shoud be right and no need fix as above explain. However, if you have other reason or case which may result in unexpected result, welcome to continue discuss.
from pegasus-java-client.
I think it is not necessary to declare volatile for local variables.
from pegasus-java-client.
Related Issues (20)
- Publish to the Central Repository? HOT 6
- Unreleased Resource: Streams
- Client API need be refactored and enhanced
- refactor and simplify the API HOT 4
- support option to enable compression and hide details of compression from users HOT 1
- There is a vulnerability in guava 28.1-jre,upgrade recommended
- feature: backup request enhancement HOT 1
- fix extreme deadlock HOT 1
- bug: batchMultiGet may not fetch all data required by the input parameter
- feature: add a app create interface to the java client
- bug: netty rejected task with RejectedExecutionException
- remove log4j from dependencies. HOT 2
- bug
- bug: unable to reconnect a replica session HOT 1
- support backup request on client side HOT 5
- Unreleased Resource: Streams HOT 1
- Double-Checked Locking
- pegasus client logs need to be improved
- Forbid large-size-value writes to Pegasus
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pegasus-java-client.