Comments (5)
Thanks for the report.
Can you try with ./run-tests.py
(https://graphviz.readthedocs.io/en/stable/development.html#tests). On my side the missing warning only happens when running with tox
. I tried downgrading to different older versions (https://tox.wiki/en/legacy/changelog.html) but so far did not manage to find a version/setting where the warning is issued as intended.
from graphviz.
I have checked it, the same.
Either the test or the code is incorrect (don't know why supported_number
is hardcoded to 3
for render
).
During the test 3
args are passed to graphviz.render()
graphviz/tests/backend/test_rendering.py
Line 31 in 6fe8c4e
graphviz/graphviz/backend/rendering.py
Lines 199 to 200 in 6fe8c4e
In this case supported_number == len(args)
, the warning is not emitted:
Lines 153 to 169 in 6fe8c4e
The warning pytest.deprecated_call
catches in this test under certain circumstances is some different warning, not the expected one and completely unrelated. The warning message can be check with match
:
https://docs.pytest.org/en/stable/reference/reference.html#pytest-deprecated-call
In the context manager form you may use the keyword argument match to assert that the warning matches a text or regex.
from graphviz.
Thank you very much for digging in: it did not occurr to me that the test was indeed incorrect (only visible in tox
).
from graphviz.
Thanks, the fix has been verified 👍
from graphviz.
Great, improved the messages (ignore cls
and self
, use singular) and their matching in the tests in e5578d3.
from graphviz.
Related Issues (20)
- Graphs not displaying inline in jupyter when created in a function HOT 2
- Make graphviz work in Jupyterlite HOT 1
- multiple incoming edges HOT 2
- Adapt for sphinx-gallery: add `_repr_html_` HOT 4
- memory issue HOT 1
- Add type annotations
- Any example of samehead or sametail would help HOT 2
- NameError: name 'doctest_mark_exe' is not defined HOT 2
- graphiviz-0.20.1 failed tests/test_quoting.py with python 3.12 HOT 2
- Docs: typo 'raise_if_result_exits' in render() argument name HOT 1
- Black colored decision box alongside root node is visible on MAC M1 on installation of graphviz HOT 2
- Edge labels overlap with edges HOT 3
- New version?🤔 HOT 8
- Fix call-signature related own `PendingDeprecationWarning` in tests HOT 6
- pytest 8.1.1: import file mismatch HOT 2
- Add support of `-Goverlap=scale` flag HOT 4
- Non-unique module names cause test failures with pytest HOT 2
- import error HOT 1
- Doesn't print the vertical bar if uses f-string HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphviz.