Code Monkey home page Code Monkey logo

Comments (7)

jtmoulia avatar jtmoulia commented on June 12, 2024 1

Just wanted to say using the MELPA package fixed the shell-maker issue for me -- danke!

from chatgpt-shell.

xenodium avatar xenodium commented on June 12, 2024

Commit ae1f3b2 makes me unable to start chatgpt shell

Ah, sorry... I'm working on getting it into melpa/melpa#8479 The changes are potentially needed (to be confirmed).

Simply removing the version works fine for me

Do you mean Version: 0.18.1? From chatgpt-shell.el or the one inshell-maker.el?

At the moment, it's looking like these two files should be considered separate packages for MELPA inclusion. For now I'd prefer to keep them in the same git repo if possible, though I'm not sure if this would create other complications.

I'm not familiar with straight, but would something like the following unblock you?

(use-package shell-maker
  :straight (:host github :repo "xenodium/chatgpt-shell" :files ("shell-maker.el")))

(use-package chatgpt-shell
  :requires shell-maker
  :straight (:host github :repo "xenodium/chatgpt-shell" :files ("chatgpt-shell.el")))

from chatgpt-shell.

jmcarcell avatar jmcarcell commented on June 12, 2024

Do you mean Version: 0.18.1? From chatgpt-shell.el or the one inshell-maker.el?

Removing (shell-maker "0.17.1"), exactly reverting ae1f3b2

Separating it into two packages works fine but it's a bit non-trivial configuration for a single repo until there is a recipe in melpa for shell-maker I guess.

Feel free to close

from chatgpt-shell.

xenodium avatar xenodium commented on June 12, 2024

Thank you.

Separating it into two packages works fine

Please use this for the time being as I'm trying to work through MELPA submission at the moment.

I'll add the snippet to the README until I figure out an alternative.

from chatgpt-shell.

meliache avatar meliache commented on June 12, 2024

Just note that I had the same issue with the elpaca file manager, which is a new package manager written from scratch from the maintainer of straight and uses similar recipes. It had the same issue. The above solution for straight should probably work for elpaca as well if you just replace :straight by :elpaca, as those are valid elpaca recipes.

But I had found also a different solution for myself: I added shell-maker to the list elpaca-ignored-dependencies. That variable is usually used in elpaca for packages that are already available in Emacs core, e.g. Eglot when using Emacs >= 29, to prevent elpaca trying to pull that from source when it's listed as a dependency. My config is:

(use-package chatgpt-shell
  :preface
  (add-to-list 'elpaca-ignored-dependencies 'shell-maker)
  :elpaca (:host github :repo "xenodium/chatgpt-shell" :files (:defaults "*.el"))
  :custom
  (chatgpt-shell-chatgpt-streaming t)
  (chatgpt-shell-openai-key
   (lambda ()
     (auth-source-pass-get 'secret "access-tokens/openai.com/emacs"))))

I'm not aware of an equivalent to elpaca-ignored-dependencies for straight.el, so the above solution is more general, but for purely elpaca this seems a bit less verbose and requires one less git clone step.

Elpaca works a bit differently that it does the dependency resolution and the beginning of reading the init, before loading any other package code, because it uses the dependency information to build the queue for asynchronously pulling and bulding the packages and loading the configuration code in the use-package/elpaca blocks

from chatgpt-shell.

xenodium avatar xenodium commented on June 12, 2024

chatgpt-shell is on MELPA now. Does that help with :straight/:elpaca?

from chatgpt-shell.

xenodium avatar xenodium commented on June 12, 2024

Just wanted to say using the MELPA package fixed the shell-maker issue for me -- danke!

Thanks for confirming. Closing.

from chatgpt-shell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.