Content of `.htaccess` is duplicated about chyrp-lite HOT 3 CLOSED

The .htaccess is not shipped because we need to set RewriteBase to the install location, which might not be the web root (so we can't just assume "/").

I think the nested conditionals are confusing PHP because the lack of closures makes the program structure ambiguous. On install the .htaccess is written because it doesn't yet exist, and because the write doesn't fail and trigger an error message, the code flows straight into the else append statement below. I'll add some closures to sort it out.

Thanks for the report.

from chyrp-lite.

It covers more installation scenarios without user interaction, but clutters the installation code and makes it difficult to ship a hardened and/or cache-optimized .htaccess.

You could leave the RewriteBase line commented out with instructions in the file and here. For user convenience, there could be a placeholder in the shipped .htaccess (like {{%dir}}), which gets replaced during the installation, so that the RewriteBase part looks ~like

Shipped

# Uncomment the next line if chyrp-lite was not installed in the web root
# RewriteBase {{%dir}}

After installing

# Uncomment the next line if chyrp-lite was not installed in the web root
# RewriteBase /path/to/chyrp

Or just skip the commenting and simply replace the placeholder.

from chyrp-lite.

That's a fair point. I don't want to make the user take manual steps, but I can shift the rewrite stuff into an external file with a placeholder and write/append to .htaccess on install. That will allow for the external source to be modified for cache-optimization etc.

I need to give some thought to how this affects the repair function in upgrade.php, and if that even makes sense any more.

from chyrp-lite.