Request: mechanism to build static libxdp without dispatcher binaries about xdp-tools HOT 8 CLOSED

from xdp-tools.

Why? You don't actually say anything about what the problem with having the dispatcher be part of the statically linked binary is?

Preference.

It's odd to provide a utility library that forces the assumption that the client-side implementation requires these extra bits. That assumption causes unnecessary build breaks when overridden. :(

from xdp-tools.

from xdp-tools.

The purpose of libxdp is to support multiple programs on a single interface, which unfortunately requires the use of the dispatcher until the kernel learns to do this natively. Building without it means that half the library won't work, which does not seem like a mode that's worth supporting...

I do see your point, but the switch is already in the code to facilitate the shared library build!

I assert that by supporting my ask, you're not really creating a huge support nightmare for the libxdp project, but you would be enabling wider flexibility for the developer community. I'd see that as a great reason to support the ask!

Well, don't override it then :)

I wouldn't if I could just press the existing 'off' switch without a hack ;-)

In all seriousness, if I provided a pull request that bubbles the -D LIBXDP_STATIC=1 command-line parameter into a build-time switch that can be toggled, would it be accepted? (Absolutely happy to do the work.)

from xdp-tools.

from xdp-tools.

Well, be that as it may, the use case I'm faced with only really needs the XSK infrastructure. Given it's a static build, the blast radius is therefore limited to the project I'm linking with the builds of libxdp I'm producing.

I've raised a PR #372 that generally just tweaks the libxdp Makefile, if anything to improve the consistency of the build recipe. I guess what you ultimately decide to do with the PR is your prerogative.

Thanks for your time and for maintaining this library. It enables some fantastic use-cases.

from xdp-tools.

Thanks for accepting the PR - we really appreciate it!!

from xdp-tools.

from xdp-tools.