Remove log. about rn-pdf-reader-js HOT 4 CLOSED

Hello, thank you very much for this awesome package! It solves my problem. Just one note. Please remove the Log "URL_TO_BASE64" every time displayed, when opening a pdf with it.

Thank you!

This is just a debug log before mount the component. You can avoid it going to your node-modules path/rn-pdf-reader-js/lib, opening the index.js and commenting the line around 229 :
componentDidMount() {
this.setState({ renderType: this.getRenderType() }, () => {
//console.debug(this.state.renderType);
this.validate();
this.init();
});
}

from rn-pdf-reader-js.

Thank you!
I dont have the log any more. Should i leave the "Issue" open for you as a reminder to remove log ?

from rn-pdf-reader-js.

Thank you! I dont have the log any more. Should i leave the "Issue" open for you as a reminder to remove log ?

I am happy to know.

I believe that you can leave it as it is. A flag to pass to the component as a prop to show logs is the best option. There are many others when something goes wrong but they are useful when we are developing and testing the code locally. A flag to disable the logs is welcome for production.

from rn-pdf-reader-js.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from rn-pdf-reader-js.