Comments (6)
Is there any difference between next
and skip
styles? I think that now EnjoyHint works well and some style rules just deprecated. Thanks for the issue, we will check it in short time.
from enjoyhint.
According to the CSS, the skip
style is supposed to pin the button in the bottom-right corner.
Having the right class for the skip button would also allow to easily retrieve it through a jQuery selector, to customize it for exemple (even if a proper way to do that would be to give access to some customization options of this button in the library).
from enjoyhint.
I fully agree about style customization. But about button's location.... Locations of the buttons are hardcoded inside library, because some users likes to see buttons near each other. In your opinion, maybe better to pass location of that button to the constructor?
from enjoyhint.
I guess the ideal would be to allow the user to customize the buttons (skip and next) the way he wants (style, location, text).
I'm not a javascript expert so I wouldn't really know what would be the best way to do that, but it could be by setting custom classes and text value through the constructor config hash for exemple.
from enjoyhint.
Hi, at the moment the button control is implemented. It will be possible either hide or display the buttons. The user will be able to do it himself. We will add it to github today or tomorrow.
from enjoyhint.
Bug is still present.
Issue is in EnjoyHint::clear() function and appears when that.nextUserClass is undefined due to wrong async execution order.
$(".enjoyhint_next_btn").removeClass(that.nextUserClass);
If that.nextUserClass === undefined, removeClass() cleans up entire element class and flushes next/skip buttons.
Following extra check makes it work perfectly:
$(".enjoyhint_next_btn").removeClass(that.nextUserClass || '');
$(".enjoyhint_skip_btn").removeClass(that.skipUserClass || '');
Feel free to make a commit.
Regards,
-- Alexander
from enjoyhint.
Related Issues (20)
- Custom button label HOT 2
- bug in the responsiveness of the steps HOT 1
- Problem with iframe.
- Resume tour after skip action && Restart tour after tour complete? HOT 1
- Custom name for prevButton and nextButton HOT 1
- Unbind all events on end tutorial ? HOT 1
- Once hidden, next button doesn't show up
- Propertie ArrowColor not working
- Enjoyhint Highlight Visibility
- Next button on mobile turns to ">"
- how to fix enjoyhint in mobileview
- ScrollTo bug still existing
- CanvasRenderingContext2D is not defined when config with nextJS
- Buttons not positioned correctly
- add image beside arrow marker HOT 1
- all buttons do not appear with jquery 1.8.3
- How do I make the background darker? HOT 1
- When searching for elements in an iframe, the hint is displayed incorrectly. Has other coordinates.
- When loading gridphp, enjoyhint triggers automatically and raising errors.
- Conditional elements in html
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enjoyhint.