Comments (9)
The scraper settings definition are the old format. That file was just copied from the original scraper a long time ago and never updated.
https://github.com/xbmc/metadata.themoviedb.org.python/blob/master/resources/settings.xml
from metadata.themoviedb.org.python.
I've made an attempt to convert the settings file. There are a couple of setting I could not figure out, but I have commented them, hopefully you can fix. The rest seem to work on my local install.
Could you check please... https://paste.kodi.tv/woluzabesi.kodi
from metadata.themoviedb.org.python.
Cheers.
How well does it work on Kodi 18? Now that I see it, there might have been an issue with unlocalized <option>
in the early implementation.
Did you try ronie's converter addon? It might be able to match that up.
from metadata.themoviedb.org.python.
I didn't test on v18.
I didn't try ronie's converter either. I sat down and plugged away following the wiki page trying to recreate the settings.
https://kodi.wiki/view/Add-on_settings_conversion
Oh, bugger, now that I look at ronies script, it could have done it for me. I spent well over an hour figuring that out :)
I thought if I did most of it, you could fix where I got it wrong or add what I ommitted.
from metadata.themoviedb.org.python.
I just tried running the script from @ronie but it does not like one of the settings
EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'ValueError'>
Error Contents: invalid literal for int() with base 10: 'Fanart.tv'
Traceback (most recent call last):
File "C:\KODI\KODI- v19 nightlies\portable_data\addons\script.settings-convert\default.py", line 844, in <module>
Main()
File "C:\KODI\KODI- v19 nightlies\portable_data\addons\script.settings-convert\default.py", line 47, in __init__
newsettings = self.updateSettings(settingsxml)
File "C:\KODI\KODI- v19 nightlies\portable_data\addons\script.settings-convert\default.py", line 110, in updateSettings
catid = xbmcaddon.Addon(self.id).getLocalizedString(int(catlabel))
ValueError: invalid literal for int() with base 10: 'Fanart.tv'
-->End of Python script error report<--
from metadata.themoviedb.org.python.
it's crashing due to this line:
category labels are expected to be a
LOCALIZE[]
string instead of hardcoded text.
if you change that line to <category>
the conversion script should finish successfully.
once done, you manually need to re-add the category label in the new settings file.
from metadata.themoviedb.org.python.
Ya, Kodi 18 support blocks this for now. I may be down with dropping that from regular releases before long, though.
from metadata.themoviedb.org.python.
oops forgot about this.
Thanks @ronie that did fix the issue.
@rmrector now that I know it is so simple to create the new settings, I'll leave it in your hands for if and when you feel like updating it. Sounds like it will happen after you drop support for v18. But yell out if you need a hand.
from metadata.themoviedb.org.python.
@rmrector
If you do update the settings, could you also consider reorganising the order of the settings. Some are a bit jumbled, like the two certification settings are separated, same with the two language settings. Also the Ratings settings are dependent on each other, so maybe indent them?
- Keep Original Title
- Preferred Language
- Search Language
- Enable fanart from TMDb
- Separate TMDb fanart with title to landscape
- Enable Trailer (YouTube)
- Preferred Certification Country
- Certification Prefix
- Default Rating from
- [indent] Add also IMDB ratings
- [indent] Add also Trakt.tv ratings
- Add multiple studios
- Add keywords as tags
fanart.tv...
- Enable artwork from fanart.tv
- Language for Fanart.tv artwork
- Prioritize fanart.tv artworks over preferred language
- Fanart.tv personal API key(optional)
from metadata.themoviedb.org.python.
Related Issues (20)
- Automatic addon submission HOT 8
- Single source of truth for the source code of this add-on? HOT 1
- UnboundLocalError: local variable 'search_results' referenced before assignment HOT 17
- Feature request: override season/episode placement with .nfo file HOT 3
- xbmc python 2.26 version not satisfied HOT 1
- Fanart language seems to be ignored HOT 9
- Kodi crashes after start when updating library on start is activated HOT 10
- TMDB artwork not scraping, fanart.tv is HOT 1
- Set Information not scraped HOT 3
- Actors - feature request HOT 4
- Fetch second page of search results HOT 8
- He can't find some posters for movies HOT 6
- Country names are not translated HOT 1
- Support for include_adult query parameter HOT 4
- Request to handle TMDB ID´s in file names HOT 1
- Missing Documentation? HOT 2
- ä,ö,ü - umlaute interpretation wrong when searching TMDB? HOT 3
- Folder name not used for search? HOT 9
- Scraping logo from TMDB HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metadata.themoviedb.org.python.