Comments (18)
I'll look into it, though i guess it can't be distributed as-is because there's currently a dependency on Google Play services which kind of defeats the purpose of F-Droid.
from kore.
(Fat fingers on previous close)
from kore.
Integrating Dominik Schuermann's Android Donations Library may be a way forward. This would also let you support donations out of Google Play.
from kore.
Thanks for pointing that out. My issue wasn't the donations, it's that there needs to be different build configurations (product flavours in Android speak), and i still haven't used them. Shouldn't be hard, but i want to get the bugs out and do a little more polish first.
from kore.
I don't see play-services dependency within the source, is it just required to be installed on the system? We add an antifeature to such apps, but we can (and do) build them. Not all of ours users are able (or want) to have a enitrely google free phone...
from kore.
You're correct, my previous comment was wrong: it doesn't depend on Play services, but it does use Google Play in-app billing.
Do you know if this is acceptable on F-Droid?
from kore.
As long as no non-free stuff is required at build time (doesn't look that way), we can build and ship it. As I said, I will mark it with an "anti feature", NonFreeDep in this case:
the application depends on a non-free application (e.g. Google Maps) - i.e. it requires it to be installed on the device, but does not include it.
Being not familiar with in-app billing, what is the point of the IAP_KEY? As we don't use api keys and such, will the app still be usable if we just use "foobar" as key?
from kore.
IAP_KEY is the key that's used to validate responses from Google Play. It might show some errors if not set correctly. If you want the correct one, drop me an email and i'll send it (synced.synapse gmail).
Sorry, but i'm not familiar with the submission process on F-Droid. What am i supposed to do to submit it?
from kore.
Well, sending it to me would be essentialy the same as including it in the source repo, since we publish sourcecode for every build: Users shouldn't be required to trust us, but should be able to operate acomplete fdroid instance themselves, building everything on their own systems.. if they want to. Such a publication of the key will most likely not be covered by the TOS you agreed to, but I might be wrong.
I just enabled the build in https://gitlab.com/fdroid/fdroiddata/commit/0d87c2ba6eb06c41f0100aebd9aacdf85911fb89 since it builds installs and startsup fine. I cannot test it anyfurther as I don't have Kodi installed. I'll post the apk tomorrow when the buildservers has finished, so you can have a look at it.
from kore.
Ok, i'll take a look tomorrow.
from kore.
Apk is available here https://f-droid.org/repository/browse/?fdid=com.syncedsynapse.kore2 , direct dl: https://f-droid.org/repo/com.syncedsynapse.kore2_3.apk
from kore.
Looks good. In-app purchases are broken, as expected, which means that there's no way to unlock the custom themes. But other functionality works fine.
from kore.
@SyncedSynapse, is there a link for alternative donation methods you want to add?
from kore.
It is blowing up as soon as you enter the settings, which is not supposed to. I'll take a look to check what can be done. Integrating with Google Play won't be possible, but it shouldn't blow up.
@krt16s No thanks.
from kore.
@logomancer Can you please confirm that you can access the settings page?
It's throwing an exception on my account, but i suspect it might be my configuration.
from kore.
This is what I get when I try to access the settings menu: https://docs.google.com/file/d/0B5GHfURMehx2VzZIOENLUFVXNVk/
Running on a Galaxy S4 running OmniROM 4.4.
from kore.
@logomancer Thank you very much. It's what i suspected. I guess that behavior is acceptable.
2 quastions:
- How will the f-droid version be updated?
- Can i close this issue?
from kore.
AFAIK F-Droid rebuilds the app whenever a new tag/release is made: https://f-droid.org/wiki/page/FAQ_-_App_Developers#Do_I_need_to_tell_you_when_I_update.3F - and yes, it's good to close. Thanks! :)
from kore.
Related Issues (20)
- TV/EPG tab missing HOT 3
- Fdroid version
- Wear version
- EventServer detection doesn't work if mute is remapped
- Kore is able to detect lib
- Missing skip buttons in notification HOT 1
- option: add media to favourites
- Missing BACKWARD and FORWARD buttons in lock screen HOT 1
- 30 sec skip (configurable)?
- Timeout when updating the Movie list
- Slow to load albums from Artist view
- Playback position when starting playing new album not updated
- [Feature request] Viewing Player Debug Info, Player Process Info HOT 1
- Kore will disconnect from Kodi on a local network if WiFi and mobile data are active (Android 12) HOT 1
- Kore volume control needs to be larger HOT 1
- Android Auto
- Add support for the Invidious add-on when sharing YouTube URLs HOT 1
- Option to have a persistent notification HOT 2
- Abandoned? HOT 7
- Cannot connect to Kodi by IP (but same Kodi works on another phone) HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kore.